Skip to content
Snippets Groups Projects
Select Git revision
  • dd_area_choosers_split_string_infinite_loop_fix
  • dailybuild_linux-x64
  • dailybuild_win32
  • master default protected
  • sqlite
  • rip_abstraction
  • dailybuild_macos-armv8
  • dd_file_lister_filanem_in_desc_color
  • mode7
  • dd_msg_reader_are_you_there_warning_improvement
  • c23-playing
  • syncterm-1.3
  • syncterm-1.2
  • test-build
  • hide_remote_connection_with_telgate
  • 638-can-t-control-c-during-a-file-search
  • add_body_to_pager_email
  • mingw32-build
  • cryptlib-3.4.7
  • ree/mastermind
  • sbbs320d
  • syncterm-1.6
  • syncterm-1.5
  • syncterm-1.4
  • sbbs320b
  • syncterm-1.3
  • syncterm-1.2
  • syncterm-1.2rc6
  • syncterm-1.2rc5
  • push
  • syncterm-1.2rc4
  • syncterm-1.2rc2
  • syncterm-1.2rc1
  • sbbs319b
  • sbbs318b
  • goodbuild_linux-x64_Sep-01-2020
  • goodbuild_win32_Sep-01-2020
  • goodbuild_linux-x64_Aug-31-2020
  • goodbuild_win32_Aug-31-2020
  • goodbuild_win32_Aug-30-2020
40 results

listfile.cpp

  • Rob Swindell's avatar
    b7aaac27
    Only use liberal file pattern matching in the terminal server listfile funcs · b7aaac27
    Rob Swindell authored
    Commit 3a3c889b (2 years ago now) changed loadfiles() to use liberal file
    matching (e.g. "syncterm.exe" matched both "syncterm.exe" and
    "syncterm_v1.2b.exe").
    
    This could produce surprising results when doing file list querieis/operations
    with the FileBase methods via JS (e.g. jsexec utils) and (now that I look at
    it), the FTP server too.
    
    So we should not have been doing liberal file matching *everywhere* loadfiles
    is used, just where it was a usability issue (due to displayed filenames being
    truncated to 12 chars for <=80 column terminals).
    
    Now solved by add/use of new liberal_filepattern() function only in the
    built-in file listing methods: sbbs_t::listfiles() and sbbs_t::listfileinfo().
    
    Note: Custom JS file searching/listing scripts may now need their own
    work-arounds for this usability issue, if they have it.
    b7aaac27
    History
    Only use liberal file pattern matching in the terminal server listfile funcs
    Rob Swindell authored
    Commit 3a3c889b (2 years ago now) changed loadfiles() to use liberal file
    matching (e.g. "syncterm.exe" matched both "syncterm.exe" and
    "syncterm_v1.2b.exe").
    
    This could produce surprising results when doing file list querieis/operations
    with the FileBase methods via JS (e.g. jsexec utils) and (now that I look at
    it), the FTP server too.
    
    So we should not have been doing liberal file matching *everywhere* loadfiles
    is used, just where it was a usability issue (due to displayed filenames being
    truncated to 12 chars for <=80 column terminals).
    
    Now solved by add/use of new liberal_filepattern() function only in the
    built-in file listing methods: sbbs_t::listfiles() and sbbs_t::listfileinfo().
    
    Note: Custom JS file searching/listing scripts may now need their own
    work-arounds for this usability issue, if they have it.