Select Git revision
rlogin.js
-
Rob Swindell authored
Bug introduced in commit 49053f31 the 'mode' value was by default, undefined. the 'timeout' value is by default, 10. When mode value/flags was not provided on the command-line, undefined was passed to bbs.rlogin_gate() as the 5th parameter, but the number 10 is passed as the 6th parameter (for time-out). The problem is, the first Number parameter passed to bbs.rlogin_gate() is interpretted as the mode value and so that becomes 10 (0x0A) which includes TG_NODESYNC thus enabling all node messages/activity being displayed to the rlogin user and interrupting their rlogin session (e.g. game play). Just make the 0 the default value for mode, like we did in telgate.js.
Rob Swindell authoredBug introduced in commit 49053f31 the 'mode' value was by default, undefined. the 'timeout' value is by default, 10. When mode value/flags was not provided on the command-line, undefined was passed to bbs.rlogin_gate() as the 5th parameter, but the number 10 is passed as the 6th parameter (for time-out). The problem is, the first Number parameter passed to bbs.rlogin_gate() is interpretted as the mode value and so that becomes 10 (0x0A) which includes TG_NODESYNC thus enabling all node messages/activity being displayed to the rlogin user and interrupting their rlogin session (e.g. game play). Just make the 0 the default value for mode, like we did in telgate.js.