Commit 087508b4 authored by Rob Swindell's avatar Rob Swindell 💬
Browse files

Address Coverity issue: filelength() can return negative value

parent 045feda8
Pipeline #2827 passed with stage
in 9 minutes and 39 seconds
/* getnode.cpp */
/* Synchronet node information retrieval functions */ /* Synchronet node information retrieval functions */
/* $Id: getnode.cpp,v 1.56 2020/08/01 22:04:03 rswindell Exp $ */
/**************************************************************************** /****************************************************************************
* @format.tab-size 4 (Plain Text/Source Code File Header) * * @format.tab-size 4 (Plain Text/Source Code File Header) *
* @format.use-tabs true (see http://www.synchro.net/ptsc_hdr.html) * * @format.use-tabs true (see http://www.synchro.net/ptsc_hdr.html) *
...@@ -17,21 +13,9 @@ ...@@ -17,21 +13,9 @@
* See the GNU General Public License for more details: gpl.txt or * * See the GNU General Public License for more details: gpl.txt or *
* http://www.fsf.org/copyleft/gpl.html * * http://www.fsf.org/copyleft/gpl.html *
* * * *
* Anonymous FTP access to the most recent released source is available at *
* ftp://vert.synchro.net, ftp://cvs.synchro.net and ftp://ftp.synchro.net *
* *
* Anonymous CVS access to the development source and modification history *
* is available at cvs.synchro.net:/cvsroot/sbbs, example: *
* cvs -d :pserver:anonymous@cvs.synchro.net:/cvsroot/sbbs login *
* (just hit return, no password is necessary) *
* cvs -d :pserver:anonymous@cvs.synchro.net:/cvsroot/sbbs checkout src *
* *
* For Synchronet coding style and modification guidelines, see * * For Synchronet coding style and modification guidelines, see *
* http://www.synchro.net/source.html * * http://www.synchro.net/source.html *
* * * *
* You are encouraged to submit any modifications (preferably in Unix diff *
* format) via e-mail to mods@synchro.net *
* *
* Note: If this box doesn't appear square, then you need to fix your tabs. * * Note: If this box doesn't appear square, then you need to fix your tabs. *
****************************************************************************/ ****************************************************************************/
...@@ -257,7 +241,7 @@ int sbbs_t::getnmsg(bool clearline) ...@@ -257,7 +241,7 @@ int sbbs_t::getnmsg(bool clearline)
return(errno); return(errno);
} }
length=(long)filelength(file); length=(long)filelength(file);
if(!length) { if(length <= 0) {
close(file); close(file);
return(0); return(0);
} }
......
...@@ -457,7 +457,7 @@ void sbbs_t::read_sif_dat(char *siffile, char *datfile) ...@@ -457,7 +457,7 @@ void sbbs_t::read_sif_dat(char *siffile, char *datfile)
return; return;
} }
length=(long)filelength(file); length=(long)filelength(file);
if(!length) { if(length <= 0) {
close(file); close(file);
return; return;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment