From 0fbdf31cedaa84d4b674ecce6e8abd4287c1331a Mon Sep 17 00:00:00 2001
From: "Rob Swindell (on Windows 11)" <rob@synchro.net>
Date: Thu, 8 Aug 2024 13:22:20 -0700
Subject: [PATCH] Make argument to bbs.batch_clear() optional (clear downlaod
queue by default)
... as appears to have been the intent
---
src/sbbs3/js_bbs.cpp | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/sbbs3/js_bbs.cpp b/src/sbbs3/js_bbs.cpp
index 216572495c..84aeff05f1 100644
--- a/src/sbbs3/js_bbs.cpp
+++ b/src/sbbs3/js_bbs.cpp
@@ -2232,10 +2232,7 @@ js_batchclear(JSContext *cx, uintN argc, jsval *arglist)
if((sbbs=js_GetPrivate(cx, JS_THIS_OBJECT(cx, arglist)))==NULL)
return(JS_FALSE);
- if(!js_argc(cx, argc, 1))
- return(JS_FALSE);
-
- if(JSVAL_TO_BOOLEAN(argv[0]))
+ if(argc > 0 && argv[0] == JSVAL_TRUE)
xfer_type = XFER_BATCH_UPLOAD;
rc=JS_SUSPENDREQUEST(cx);
@@ -4530,8 +4527,8 @@ static jsSyncMethodSpec js_bbs_functions[] = {
,JSDOCSTR("Add file list to batch download queue")
,310
},
- {"batch_clear", js_batchclear, 1, JSTYPE_BOOLEAN, JSDOCSTR("upload=false")
- ,JSDOCSTR("Clear batch download (or upload) queue")
+ {"batch_clear", js_batchclear, 1, JSTYPE_BOOLEAN, JSDOCSTR("[upload_queue=false]")
+ ,JSDOCSTR("Clear the batch download or batch upload queue")
,320
},
{"view_file", js_viewfile, 1, JSTYPE_BOOLEAN, JSDOCSTR("filename")
--
GitLab