From 11b4ce2c80d4373b770638e67a232d17309e851a Mon Sep 17 00:00:00 2001
From: Eric Oulashin <eric.oulashin@gmail.com>
Date: Mon, 20 Mar 2023 10:40:12 -0700
Subject: [PATCH] DD area choosers: Replaced hardcoded high-ascii single line
 character with a variable defining it via hex code (for the help screens)

---
 xtrn/DDAreaChoosers/DDFileAreaChooser.js | 17 ++++++++++++++---
 xtrn/DDAreaChoosers/DDMsgAreaChooser.js  | 17 ++++++++++++++---
 2 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/xtrn/DDAreaChoosers/DDFileAreaChooser.js b/xtrn/DDAreaChoosers/DDFileAreaChooser.js
index 3c2521a6fa..28c1825404 100644
--- a/xtrn/DDAreaChoosers/DDFileAreaChooser.js
+++ b/xtrn/DDAreaChoosers/DDFileAreaChooser.js
@@ -113,6 +113,9 @@ if (typeof(KEY_PAGEDN) === "string")
 var UP_ARROW = ascii(24);
 var DOWN_ARROW = ascii(25);
 
+// Characters for display
+var HORIZONTAL_SINGLE = "\xC4";
+
 // Misc. defines
 var ERROR_WAIT_MS = 1500;
 var SEARCH_TIMEOUT_MS = 10000;
@@ -1808,7 +1811,11 @@ function DDFileAreaChooser_showHelpScreen(pLightbar, pClearScreen)
 	else
 		console.print("\x01n");
 	console.center("\x01c\x01hDigital Distortion File Area Chooser");
-	console.center("\x01k哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪");
+	var lineStr = "";
+	for (var i = 0; i < 36; ++i)
+		lineStr += HORIZONTAL_SINGLE;
+	console.attributes = "HK";
+	console.center(lineStr);
 	console.center("\x01n\x01cVersion \x01g" + DD_FILE_AREA_CHOOSER_VERSION +
 	               " \x01w\x01h(\x01b" + DD_FILE_AREA_CHOOSER_VER_DATE + "\x01w)");
 	console.crlf();
@@ -1824,7 +1831,9 @@ function DDFileAreaChooser_showHelpScreen(pLightbar, pClearScreen)
 		console.crlf();
 		console.print("\x01n\x01cThe lightbar interface also allows up & down navigation through the lists:");
 		console.crlf();
-		console.print("\x01k\x01h哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪");
+		console.attributes = "HK";
+		for (var i = 0; i < 74; ++i)
+			console.print(HORIZONTAL_SINGLE);
 		console.crlf();
 		console.print("\x01n\x01c\x01hUp arrow\x01n\x01c: Move the cursor up one line");
 		console.crlf();
@@ -1849,7 +1858,9 @@ function DDFileAreaChooser_showHelpScreen(pLightbar, pClearScreen)
 	console.crlf();
 	console.print("Additional keyboard commands:");
 	console.crlf();
-	console.print("\x01k\x01h哪哪哪哪哪哪哪哪哪哪哪哪哪哪�");
+	for (var i = 0; i < 29; ++i)
+			console.print(HORIZONTAL_SINGLE);
+	console.attributes = "HK";
 	console.crlf();
 	console.print("\x01n\x01c\x01h?\x01n\x01c: Show this help screen");
 	console.crlf();
diff --git a/xtrn/DDAreaChoosers/DDMsgAreaChooser.js b/xtrn/DDAreaChoosers/DDMsgAreaChooser.js
index 30a30c4e19..1e2a0fcc8e 100644
--- a/xtrn/DDAreaChoosers/DDMsgAreaChooser.js
+++ b/xtrn/DDAreaChoosers/DDMsgAreaChooser.js
@@ -119,6 +119,9 @@ if (typeof(KEY_PAGEDN) === "string")
 var UP_ARROW = ascii(24);
 var DOWN_ARROW = ascii(25);
 
+// Characters for display
+var HORIZONTAL_SINGLE = "\xC4";
+
 // Misc. defines
 var ERROR_WAIT_MS = 1500;
 var SEARCH_TIMEOUT_MS = 10000;
@@ -2184,7 +2187,11 @@ function DDMsgAreaChooser_showHelpScreen(pLightbar, pClearScreen)
 	else
 		console.print("\1n");
 	console.center("\1c\1hDigital Distortion Message Area Chooser");
-	console.center("\1k哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪�");
+	var lineStr = "";
+	for (var i = 0; i < 39; ++i)
+		lineStr += HORIZONTAL_SINGLE;
+	console.attributes = "HK";
+	console.center(lineStr);
 	console.center("\1n\1cVersion \1g" + DD_MSG_AREA_CHOOSER_VERSION +
 	               " \1w\1h(\1b" + DD_MSG_AREA_CHOOSER_VER_DATE + "\1w)");
 	console.crlf();
@@ -2200,7 +2207,9 @@ function DDMsgAreaChooser_showHelpScreen(pLightbar, pClearScreen)
 		console.crlf();
 		console.print("\1n\1cThe lightbar interface also allows up & down navigation through the lists:");
 		console.crlf();
-		console.print("\1k\1h哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪哪");
+		console.attributes = "HK";
+		for (var i = 0; i < 74; ++i)
+			console.print(HORIZONTAL_SINGLE);
 		console.crlf();
 		console.print("\1n\1c\1hUp arrow\1n\1c: Move the cursor up one line");
 		console.crlf();
@@ -2225,7 +2234,9 @@ function DDMsgAreaChooser_showHelpScreen(pLightbar, pClearScreen)
 	console.crlf();
 	console.print("Additional keyboard commands:");
 	console.crlf();
-	console.print("\1k\1h哪哪哪哪哪哪哪哪哪哪哪哪哪哪�");
+	console.attributes = "HK";
+	for (var i = 0; i < 29; ++i)
+		console.print(HORIZONTAL_SINGLE);
 	console.crlf();
 	console.print("\1n\1c\1h?\1n\1c: Show this help screen");
 	console.crlf();
-- 
GitLab