From 13ce5ce871a2f114591e3218452fbedc49cb59fb Mon Sep 17 00:00:00 2001
From: rswindell <>
Date: Wed, 17 Oct 2001 19:20:46 +0000
Subject: [PATCH] Eliminated warnings exposed by BCC build.

---
 src/sbbs3/js_console.cpp | 1 -
 src/sbbs3/js_file.c      | 4 +---
 src/sbbs3/js_file_area.c | 2 +-
 src/sbbs3/js_global.c    | 1 -
 src/sbbs3/js_socket.c    | 6 ++----
 src/sbbs3/js_system.c    | 2 +-
 src/sbbs3/js_user.c      | 4 ++--
 7 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/src/sbbs3/js_console.cpp b/src/sbbs3/js_console.cpp
index 7c21ebfa2e..a62e93d01a 100644
--- a/src/sbbs3/js_console.cpp
+++ b/src/sbbs3/js_console.cpp
@@ -608,7 +608,6 @@ js_printtail(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 static JSBool
 js_editfile(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 {
-	long		mode=0;
     JSString*	str;
 	sbbs_t*		sbbs;
 
diff --git a/src/sbbs3/js_file.c b/src/sbbs3/js_file.c
index 696d2f203b..c6443b4a25 100644
--- a/src/sbbs3/js_file.c
+++ b/src/sbbs3/js_file.c
@@ -124,7 +124,7 @@ js_open(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 {
 	char*		mode="w+";	/* default mode */
 	uintN		i;
-	JSBool		bufsize=2*1024;
+	jsint		bufsize=2*1024;
 	JSString*	str;
 	private_t*	p;
 
@@ -459,7 +459,6 @@ js_writeall(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
     jsuint      i;
     jsuint      limit;
     JSObject*	array;
-    JSObject*	elem;
     jsval       elemval;
 	private_t*	p;
 
@@ -483,7 +482,6 @@ js_writeall(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
     for(i=0;i<limit;i++) {
         if(!JS_GetElement(cx, array, i, &elemval))
 			break;
-        elem = JSVAL_TO_OBJECT(elemval);
         js_writeln(cx, obj, 1, &elemval, rval);
 		if(*rval!=BOOLEAN_TO_JSVAL(JSVAL_TRUE))
 			break;
diff --git a/src/sbbs3/js_file_area.c b/src/sbbs3/js_file_area.c
index f5cf033add..9dac7beddc 100644
--- a/src/sbbs3/js_file_area.c
+++ b/src/sbbs3/js_file_area.c
@@ -68,7 +68,7 @@ JSObject* DLLCALL js_CreateFileAreaObject(JSContext* cx, JSObject* parent, scfg_
 	JSObject*	lib_list;
 	JSObject*	dir_list;
 	jsval		val;
-	jsint		index;
+	jsuint		index;
 	uint		l,d;
 	JSBool		found;
 
diff --git a/src/sbbs3/js_global.c b/src/sbbs3/js_global.c
index 481ac62195..ebe7d2e6a0 100644
--- a/src/sbbs3/js_global.c
+++ b/src/sbbs3/js_global.c
@@ -244,7 +244,6 @@ js_ascii(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 static JSBool
 js_strip_ctrl(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 {
-	ulong		sum=0;
 	char*		p;
 	JSString*	js_str;
 
diff --git a/src/sbbs3/js_socket.c b/src/sbbs3/js_socket.c
index a11ff5849b..c4ec7cc152 100644
--- a/src/sbbs3/js_socket.c
+++ b/src/sbbs3/js_socket.c
@@ -150,7 +150,6 @@ js_close(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 static JSBool
 js_bind(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 {
-	int			i;
 	SOCKADDR_IN	addr;
 	private_t*	p;
 
@@ -163,7 +162,7 @@ js_bind(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 	if(argc)
 		addr.sin_port = (ushort)JSVAL_TO_INT(argv[0]);
 
-	if((i=bind(p->sock, (struct sockaddr *) &addr, sizeof (addr)))!=0) {
+	if(bind(p->sock, (struct sockaddr *) &addr, sizeof (addr))!=0) {
 		p->last_error=ERROR_VALUE;
 		dbprintf(TRUE, p, "bind failed with error %d",ERROR_VALUE);
 		*rval = BOOLEAN_TO_JSVAL(JS_FALSE);
@@ -178,7 +177,6 @@ js_bind(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 static JSBool
 js_connect(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 {
-	int			i;
 	ulong		ip_addr;
 	ushort		port;
 	JSString*	str;
@@ -208,7 +206,7 @@ js_connect(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 	addr.sin_family = AF_INET;
 	addr.sin_port   = htons(port);
 
-	if((i=connect(p->sock, (struct sockaddr *)&addr, sizeof(addr)))!=0) {
+	if(connect(p->sock, (struct sockaddr *)&addr, sizeof(addr))!=0) {
 		p->last_error=ERROR_VALUE;
 		dbprintf(TRUE, p, "connect failed with error %d",ERROR_VALUE);
 		*rval = BOOLEAN_TO_JSVAL(JS_FALSE);
diff --git a/src/sbbs3/js_system.c b/src/sbbs3/js_system.c
index 04f5d830f7..8b6c89a11b 100644
--- a/src/sbbs3/js_system.c
+++ b/src/sbbs3/js_system.c
@@ -634,7 +634,7 @@ static JSBool js_node_get(JSContext *cx, JSObject *obj, jsval id, jsval *vp)
 static JSBool js_node_set(JSContext *cx, JSObject *obj, jsval id, jsval *vp)
 {
 	uint		node_num;
-	uint		val=0;
+	jsint		val=0;
     jsint       tiny;
 	node_t		node;
 	scfg_t*		cfg;
diff --git a/src/sbbs3/js_user.c b/src/sbbs3/js_user.c
index b05f313eb5..33e814dcf7 100644
--- a/src/sbbs3/js_user.c
+++ b/src/sbbs3/js_user.c
@@ -322,7 +322,7 @@ static JSBool js_user_set(JSContext *cx, JSObject *obj, jsval id, jsval *vp)
 {
 	char*		str;
 	char		tmp[64];
-	ulong		val;
+	jsint		val;
 	ulong		usermisc;
     jsint       tiny;
 	JSString*	js_str;
@@ -341,7 +341,7 @@ static JSBool js_user_set(JSContext *cx, JSObject *obj, jsval id, jsval *vp)
 
 	switch(tiny) {
 		case USER_PROP_NUMBER:
-			JS_ValueToInt32(cx, *vp, &p->usernumber);
+			JS_ValueToInt32(cx, *vp, (jsint*)&p->usernumber);
 			break;
 		case USER_PROP_ALIAS:
 			/* update USER.DAT */
-- 
GitLab