From 1c1dbf2f4c81de575534d8b96dd349339c2ddcfc Mon Sep 17 00:00:00 2001
From: "Rob Swindell (on Debian Linux)" <rob@synchro.net>
Date: Sun, 12 Jan 2025 19:00:43 -0800
Subject: [PATCH] Fix system.datestr(0) returning garbage

Actually use the return value of datestr()

Fixes issue reported by Deuce, regression introduced in commit 490e86fa38c
---
 src/sbbs3/js_system.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/sbbs3/js_system.c b/src/sbbs3/js_system.c
index 52e6312715..ffe4f287c3 100644
--- a/src/sbbs3/js_system.c
+++ b/src/sbbs3/js_system.c
@@ -1293,8 +1293,7 @@ js_datestr(JSContext *cx, uintN argc, jsval *arglist)
 		}
 		JS_ValueToECMAUint32(cx,argv[0],(uint32_t*)&t);
 	}
-	datestr(sys->cfg,t,str);
-	if((js_str = JS_NewStringCopyZ(cx, str))==NULL)
+	if((js_str = JS_NewStringCopyZ(cx, datestr(sys->cfg, t, str))==NULL)
 		return(JS_FALSE);
 
 	JS_SET_RVAL(cx, arglist, STRING_TO_JSVAL(js_str));
-- 
GitLab