From 265db90af9fb12a555b70ee2e63568f1c64a916d Mon Sep 17 00:00:00 2001 From: rswindell <> Date: Sat, 20 Dec 2008 04:17:58 +0000 Subject: [PATCH] Log an error message if logoutuserdat() fails. --- src/sbbs3/ftpsrvr.c | 3 ++- src/sbbs3/mailsrvr.c | 6 ++++-- src/sbbs3/services.c | 3 ++- src/sbbs3/websrvr.c | 3 ++- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/sbbs3/ftpsrvr.c b/src/sbbs3/ftpsrvr.c index e98ec3849a..b77f09a184 100644 --- a/src/sbbs3/ftpsrvr.c +++ b/src/sbbs3/ftpsrvr.c @@ -4469,7 +4469,8 @@ static void ctrl_thread(void* arg) if(user.number) { /* Update User Statistics */ - logoutuserdat(&scfg, &user, time(NULL), logintime); + if(!logoutuserdat(&scfg, &user, time(NULL), logintime)) + lprintf(LOG_ERR,"%04d !ERROR in logoutuserdat",sock); /* Remove QWK-pack semaphore file (if left behind) */ sprintf(str,"%spack%04u.now",scfg.data_dir,user.number); remove(str); diff --git a/src/sbbs3/mailsrvr.c b/src/sbbs3/mailsrvr.c index b1c5b4a251..1512229b85 100644 --- a/src/sbbs3/mailsrvr.c +++ b/src/sbbs3/mailsrvr.c @@ -1216,8 +1216,10 @@ static void pop3_thread(void* arg) ,socket, user.alias, buf); sockprintf(socket,"-ERR UNSUPPORTED COMMAND: %s",buf); } - if(user.number) - logoutuserdat(&scfg,&user,time(NULL),client.time); + if(user.number) { + if(!logoutuserdat(&scfg,&user,time(NULL),client.time)) + lprintf(LOG_ERR,"%04d !ERROR in logoutuserdat", socket); + } } while(0); diff --git a/src/sbbs3/services.c b/src/sbbs3/services.c index 2728e6b0a3..9c058d3a45 100644 --- a/src/sbbs3/services.c +++ b/src/sbbs3/services.c @@ -559,7 +559,8 @@ js_logout(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval) return(JS_TRUE); rc=JS_SUSPENDREQUEST(cx); - logoutuserdat(&scfg,&client->user,time(NULL),client->logintime); + if(!logoutuserdat(&scfg,&client->user,time(NULL),client->logintime)) + lprintf(LOG_ERR,"%04d !ERROR in logoutuserdat",client->socket); lprintf(LOG_INFO,"%04d %s Logging out %s" ,client->socket,client->service->protocol,client->user.alias); diff --git a/src/sbbs3/websrvr.c b/src/sbbs3/websrvr.c index c059d48c2e..a4bb491fc6 100644 --- a/src/sbbs3/websrvr.c +++ b/src/sbbs3/websrvr.c @@ -1374,7 +1374,8 @@ void http_logoff(http_session_t* session, SOCKET socket, int line) ,socket,session->user.number, line); SAFECOPY(session->username,unknown); - logoutuserdat(&scfg, &session->user, time(NULL), session->logon_time); + if(!logoutuserdat(&scfg, &session->user, time(NULL), session->logon_time)) + lprintf(LOG_ERR,"%04d !ERROR in logoutuserdat", socket); memset(&session->user,0,sizeof(session->user)); session->last_user_num=session->user.number; } -- GitLab