Synchronet now requires the libarchive development package (e.g. libarchive-dev on Debian-based Linux distros, for more info) to build successfully.

Commit 2f0381d2 authored by rswindell's avatar rswindell

Added support to console.print() for an optional P_* mode argument. Must

be called as console.print(string, number), the number will be interpretted
as the P_* mode flags value. Otherwise, all arguments are converted to strings
and printed (as before).
If anyone was calling console.print(string, number), they will get different
behavior now. I couldn't find any evidence of anyone using this syntax for
console.print(), so I think this should be okay.
Only a limited set of P_* flags are supported (e.g. P_PETSCII, P_UTF8) - far
fewer than console.putmsg(), but console.putmsg() is much more heavy weight
and supports a lot more "features" likely to interfere with the expected user
output. In general, try to use console.putmsg() only when printing multi-line
text strings or when @-code expansion is needed. Otherwise, console.print()
is usually better.
parent e194fba4
......@@ -1084,13 +1084,24 @@ js_print(JSContext *cx, uintN argc, jsval *arglist)
char* cstr=NULL;
size_t cstr_sz=0;
jsrefcount rc;
int32 pmode = 0;
if((sbbs=(sbbs_t*)js_GetClassPrivate(cx, JS_THIS_OBJECT(cx, arglist), &js_console_class))==NULL)
JS_SET_RVAL(cx, arglist, JSVAL_VOID);
for (i = 0; i < argc; i++) {
if(argc == 2 && JSVAL_IS_STRING(argv[0]) && JSVAL_IS_NUMBER(argv[1])) {
JSVALUE_TO_RASTRING(cx, argv[0], cstr, &cstr_sz, NULL);
if(!JS_ValueToInt32(cx, argv[1], &pmode))
return JS_FALSE;
sbbs->bputs(cstr, pmode);
else for (i=0; i < argc; i++) {
JSVALUE_TO_RASTRING(cx, argv[i], cstr, &cstr_sz, NULL);
......@@ -1975,8 +1986,10 @@ static jsSyncMethodSpec js_console_functions[] = {
,JSDOCSTR("beep for <i>count</i> number of times (default count is 1)")
{"print", js_print, 1, JSTYPE_VOID, JSDOCSTR("value [,value]")
,JSDOCSTR("display one or more values as strings (supports Ctrl-A codes, Telnet-escaping, auto-screen pausing, etc.)")
{"print", js_print, 1, JSTYPE_VOID, JSDOCSTR("<value [,value][...]> or <string [,mode=<tt>P_NONE</tt>]>")
,JSDOCSTR("display one or more values as strings (supports Ctrl-A codes, Telnet-escaping, auto-screen pausing, etc.).<br>"
"Supports a limited set of <tt>P_*</tt> flags, e.g. <tt>P_PETSCII</tt> and <tt>P_UTF8</tt>."
{"write", js_write, 1, JSTYPE_VOID, JSDOCSTR("value [,value]")
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment