From 3a85f064877fa0c8fbc92eed76121d36af659ec2 Mon Sep 17 00:00:00 2001
From: mcmlxxix <>
Date: Tue, 26 Jul 2011 18:57:12 +0000
Subject: [PATCH] check if callback is a function throw exception on missing
host or port
---
exec/load/json-client.js | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/exec/load/json-client.js b/exec/load/json-client.js
index e64547b41a..152fd57dbc 100644
--- a/exec/load/json-client.js
+++ b/exec/load/json-client.js
@@ -71,16 +71,12 @@ function JSONClient(serverAddr,serverPort) {
this.VERSION = "$Revision$".split(' ')[1];
this.serverAddr=serverAddr;
- if(this.serverAddr==undefined) {
- this.serverAddr="bbs.thebrokenbubble.com";
- log(LOG_DEBUG,"using default server address: " + this.serverAddr);
- }
+ if(this.serverAddr==undefined)
+ throw("no host specified");
this.serverPort=serverPort;
- if(this.serverPort==undefined) {
- this.serverPort=10088;
- log(LOG_DEBUG,"using default server port: " + this.serverPort);
- }
+ if(this.serverPort==undefined)
+ throw("no port specified");
this.settings={
CONNECTION_TIMEOUT: 5,
@@ -247,7 +243,7 @@ function JSONClient(serverAddr,serverPort) {
var packet=this.receive();
if(!packet)
return false;
- else if(this.callback)
+ else if(typeof this.callback == "function")
this.callback(packet.data);
else
this.updates.push(packet.data);
--
GitLab