Synchronet now requires the libarchive development package (e.g. libarchive-dev on Debian-based Linux distros, for more info) to build successfully.

Commit 3aacaa64 authored by Rob Swindell's avatar Rob Swindell 💬

Fix sendmail bug introduced in 6851910b.

The "MAIL FROM" command argument must always be enclosed in angle-brackets. Some mail servers (e.g. gmail, aol) would reject messages not delivered in this manner, e.g.: replied with:
"501 Syntax error in parameters or arguments tnmpmscs"
instead of the expected reply:
"250 ..." replied with:
"555 5.5.2 Syntax error. o6si11103060plk.317 - gsmtp"
instead of the expected reply:
"250 ..."
parent 8a7b7308
Pipeline #526 passed with stage
in 15 minutes and 40 seconds
......@@ -5620,9 +5620,9 @@ static void sendmail_thread(void* arg)
if(msg.from_net.type==NET_INTERNET && msg.reverse_path!=NULL)
SAFECOPY(fromaddr, msg.reverse_path);
angle_bracket(fromaddr, sizeof(fromaddr), msg.reverse_path);
SAFEPRINTF(fromaddr, "<%s>", usermailaddr(&scfg, str, msg.from));
angle_bracket(fromaddr, sizeof(fromaddr), usermailaddr(&scfg, str, msg.from));
char sender_info[512];
if(msg.from_ext != NULL)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment