From 3d40d00897a652020533de62b05437356ace6339 Mon Sep 17 00:00:00 2001
From: Rob Swindell <rob@synchro.net>
Date: Sun, 4 Apr 2021 14:29:53 -0700
Subject: [PATCH] dirnum is unsigned, so do not check for negative
CID 330990
---
src/sbbs3/js_filebase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sbbs3/js_filebase.c b/src/sbbs3/js_filebase.c
index 304c31d44a..8a1219389c 100644
--- a/src/sbbs3/js_filebase.c
+++ b/src/sbbs3/js_filebase.c
@@ -1533,7 +1533,7 @@ js_filebase_constructor(JSContext *cx, uintN argc, jsval *arglist)
#endif
p->smb.dirnum = getdirnum(scfg, base);
- if(p->smb.dirnum >= 0 && p->smb.dirnum < scfg->total_dirs) {
+ if(p->smb.dirnum < scfg->total_dirs) {
safe_snprintf(p->smb.file, sizeof(p->smb.file), "%s%s"
,scfg->dir[p->smb.dirnum]->data_dir, scfg->dir[p->smb.dirnum]->code);
} else { /* unknown code */
--
GitLab