From 3ead8a4d227af07c81c2c8e54b2fd6970905e4a4 Mon Sep 17 00:00:00 2001 From: Rob Swindell <rob@synchro.net> Date: Sat, 9 Jan 2021 13:43:40 -0800 Subject: [PATCH] Don't delete pack####.now upon FTP-logoff When a user logins to the FTP server concurrently, this creates a race condition with an/the other FTP session that may be creating/ downloading a QWK packet. On Vertrauen, this results in the occasional error removing the file since it was removed unexpectedly: !ERROR 2 (No such file or directory) in main.cpp line 2747 (event_thread) removing "/sbbs/data/pack1111.now" access=0 --- src/sbbs3/ftpsrvr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/sbbs3/ftpsrvr.c b/src/sbbs3/ftpsrvr.c index bf546b3985..ab67deb720 100644 --- a/src/sbbs3/ftpsrvr.c +++ b/src/sbbs3/ftpsrvr.c @@ -4971,9 +4971,6 @@ static void ctrl_thread(void* arg) /* Update User Statistics */ if(!logoutuserdat(&scfg, &user, time(NULL), logintime)) lprintf(LOG_ERR,"%04d <%s> !ERROR in logoutuserdat", sock, user.alias); - /* Remove QWK-pack semaphore file (if left behind) */ - sprintf(str,"%spack%04u.now",scfg.data_dir,user.number); - ftp_remove(sock, __LINE__, str, user.alias); lprintf(LOG_INFO,"%04d <%s> logged off", sock, user.alias); } -- GitLab