From 3edd9127d7e86dac907b876311e315fc1c78c763 Mon Sep 17 00:00:00 2001
From: cyan <>
Date: Wed, 2 Jun 2010 14:28:48 +0000
Subject: [PATCH] * Don't assume success by default.

---
 src/sbbs3/js_global.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/sbbs3/js_global.c b/src/sbbs3/js_global.c
index 3a35b4a3e3..16fb1c0967 100644
--- a/src/sbbs3/js_global.c
+++ b/src/sbbs3/js_global.c
@@ -2797,7 +2797,7 @@ js_kill(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 {
 	int32		pid=0;
 	int32		sig=0;
-	int			ds=0; /* assumes success by default */
+	int			ds;
 	jsrefcount	rc;
 
 	if(JSVAL_IS_VOID(argv[0]))
@@ -2811,7 +2811,8 @@ js_kill(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
 	JS_ValueToInt32(cx,argv[1],&pid);
 	
 	rc=JS_SUSPENDREQUEST(cx);
-	if (kill(sig, pid) == -1) /* failure */
+	ds = kill(sig, pid);
+	if (ds == -1)
 		ds = errno;
 	JS_RESUMEREQUEST(cx, rc);
 	JS_NewNumberValue(cx,ds,rval);
-- 
GitLab