From 4610fc7b454e891fb09f2663d837bbff42bb2a98 Mon Sep 17 00:00:00 2001
From: "Rob Swindell (on Debian Linux)" <rob@synchro.net>
Date: Sun, 8 Dec 2024 12:31:55 -0800
Subject: [PATCH] Fix incorrect use of sizeof in node_vstatus and node_activity
This would cause the "Logout" status and multinode chat activity
strings to be truncated to 3 or 7 chars.
CID 515713 and 515715
---
src/sbbs3/userdat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/sbbs3/userdat.c b/src/sbbs3/userdat.c
index 62c9347089..9e3fbe858f 100644
--- a/src/sbbs3/userdat.c
+++ b/src/sbbs3/userdat.c
@@ -1417,7 +1417,7 @@ char* node_vstatus(scfg_t* cfg, node_t* node, char* str, size_t size)
case NODE_LOGON:
return cfg->text != NULL ? cfg->text[NodeStatusLogon] : "At login prompt";
case NODE_LOGOUT:
- snprintf(str, sizeof str, cfg->text != NULL ? cfg->text[NodeStatusLogout] : "Logging out %s", username(cfg,node->useron,tmp));
+ snprintf(str, size, cfg->text != NULL ? cfg->text[NodeStatusLogout] : "Logging out %s", username(cfg,node->useron,tmp));
return str;
case NODE_EVENT_WAITING:
return cfg->text != NULL ? cfg->text[NodeStatusEventWaiting] : "Waiting for all nodes to become inactive";
@@ -1509,7 +1509,7 @@ char* node_activity(scfg_t* cfg, node_t* node, char* str, size_t size, int num)
break;
case NODE_MCHT:
if(node->aux != 0)
- snprintf(str, sizeof str
+ snprintf(str, size
,cfg->text != NULL ? cfg->text[NodeActivityChatChannel] : "in multinode chat channel %d"
,node->aux & 0xff);
else
--
GitLab