Synchronet now requires the libarchive development package (e.g. libarchive-dev on Debian-based Linux distros, libarchive.org for more info) to build successfully.

Commit 4e9ff218 authored by Rob Swindell's avatar Rob Swindell 💬

Fix apparent memory leak in js_listening_socket_constructor()

The socket set allocated by xpms_create() was never freed. Found by Coverity.
parent a6efc1be
Pipeline #1342 passed with stage
in 9 minutes and 29 seconds
......@@ -396,8 +396,9 @@ static void js_finalize_socket(JSContext *cx, JSObject *obj)
do_js_close(p, true);
if(p->hostname)
free(p->hostname);
if(!p->external)
free(p->set);
free(p->hostname);
free(p);
JS_SetPrivate(cx, obj, NULL);
......@@ -2817,7 +2818,6 @@ js_listening_socket_constructor(JSContext *cx, uintN argc, jsval *arglist)
JS_ReportError(cx, "Unable to create socket set");
goto fail;
}
// A for Digitman: "Nothing." -- DigitalMan (via Mumble)
if (obj == NULL) {
JSVALUE_TO_MSTRING(cx, argv[0], interface, NULL);
HANDLE_PENDING(cx, interface);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment