From 4fe669a94fa5588646b77d911117df56094898c5 Mon Sep 17 00:00:00 2001
From: rswindell <>
Date: Sun, 26 Jan 2014 03:13:55 +0000
Subject: [PATCH] Fix observed NULL pointer deference (pass to sub_mkgmt(),
from time_gm()). Added comment about usage of gmtime() vs. gmtime_r().
---
src/sbbs3/websrvr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/sbbs3/websrvr.c b/src/sbbs3/websrvr.c
index b229a8e092..160801feea 100644
--- a/src/sbbs3/websrvr.c
+++ b/src/sbbs3/websrvr.c
@@ -428,8 +428,8 @@ time_gm(struct tm *tm)
/* save value in case *tm is overwritten by gmtime() */
sec = tm->tm_sec;
- tm2 = gmtime(&t);
- if ((t2 = sub_mkgmt(tm2)) == (time_t) -1)
+ tm2 = gmtime(&t); /* why not use gmtime_r instead? */
+ if (tm2 == NULL || (t2 = sub_mkgmt(tm2)) == (time_t) -1)
return (time_t) -1;
if (t2 < t || tm2->tm_sec != sec) {
--
GitLab