From 54043e269bf5f46d476cd15e5d811cf3ce9d4173 Mon Sep 17 00:00:00 2001
From: rswindell <>
Date: Mon, 5 Sep 2005 20:21:02 +0000
Subject: [PATCH] Bug-fix: double-free in Queue finalizer (q is already freed
 in msgQueueDetach).

---
 src/sbbs3/js_queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sbbs3/js_queue.c b/src/sbbs3/js_queue.c
index 501838d694..30ed4cd746 100644
--- a/src/sbbs3/js_queue.c
+++ b/src/sbbs3/js_queue.c
@@ -64,7 +64,7 @@ static void js_finalize_queue(JSContext *cx, JSObject *obj)
 		return;
 	
 	if(msgQueueDetach(q)==0 && (n=listFindNode(&named_queues,q,/* length=0 for ptr compare */0))!=NULL)
-		listRemoveNode(&named_queues,n,TRUE);
+		listRemoveNode(&named_queues,n,FALSE);
 
 	JS_SetPrivate(cx, obj, NULL);
 }
-- 
GitLab