From 63cec349ee714376a2649e5ff4fd26c35eae66b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Deuc=D0=B5?= <shurd@sasktel.net>
Date: Thu, 22 Feb 2024 09:49:40 -0500
Subject: [PATCH] Remove need_copy variable when it won't be used.
Fixes Coverity issue.
---
src/xpdev/xpbeep.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/xpdev/xpbeep.c b/src/xpdev/xpbeep.c
index 8cd0ab8324..13243e4d9d 100644
--- a/src/xpdev/xpbeep.c
+++ b/src/xpdev/xpbeep.c
@@ -832,7 +832,9 @@ static bool
do_xp_play_sample(unsigned char *sampo, size_t sz, int *freed)
{
unsigned char *samp;
+#if defined(WITH_PORTAUDIO) || defined(_WIN32) || defined(WITH_SDL_AUDIO)
int need_copy = 0;
+#endif
#ifdef AFMT_U8
int wr;
int i;
@@ -853,6 +855,7 @@ do_xp_play_sample(unsigned char *sampo, size_t sz, int *freed)
need_copy = 1;
#endif
+#if defined(WITH_PORTAUDIO) || defined(_WIN32) || defined(WITH_SDL_AUDIO)
if (freed)
*freed = need_copy;
if (need_copy) {
@@ -869,6 +872,11 @@ do_xp_play_sample(unsigned char *sampo, size_t sz, int *freed)
else {
samp = sampo;
}
+#else
+ if (freed)
+ *freed = 0;
+ samp = sampo;
+#endif
#ifdef WITH_PULSEAUDIO
if(handle_type==SOUND_DEVICE_PULSEAUDIO) {
--
GitLab