From 688b566bd32ddb4bee07d60ec2255f99738eec0a Mon Sep 17 00:00:00 2001
From: Rob Swindell <rob@synchro.net>
Date: Wed, 4 Nov 2020 23:59:12 -0800
Subject: [PATCH] Fix logged garbage observed in release rPi3 builds
The "insert key into keybuf" log line could contain garbage. Apparently
in a release build, the nested scope stack variable is actually invalid
after the end of the scope. Weird.
---
src/sbbs3/getkey.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/sbbs3/getkey.cpp b/src/sbbs3/getkey.cpp
index f4a0258cca..20d9d59b3c 100644
--- a/src/sbbs3/getkey.cpp
+++ b/src/sbbs3/getkey.cpp
@@ -475,13 +475,14 @@ void sbbs_t::pause()
/****************************************************************************/
void sbbs_t::ungetkey(char ch, bool insert)
{
+ char dbg[2] = {};
#if 0 /* this way breaks ansi_getxy() */
RingBufWrite(&inbuf,(uchar*)&ch,sizeof(uchar));
#else
if(keybuf_space()) {
char* p = c_escape_char(ch);
if(p == NULL) {
- char dbg[2] = { ch, 0 };
+ dbg[0] = ch;
p = dbg;
}
lprintf(LOG_DEBUG, "%s key into keybuf: %02X (%s)", insert ? "insert" : "append", ch, p);
--
GitLab