From 6f59519e895e42dfbc551a3bd115a4830ae6df7f Mon Sep 17 00:00:00 2001
From: rswindell <>
Date: Tue, 20 Feb 2018 11:23:18 +0000
Subject: [PATCH] Check the return value of mkdir() to make Coverity happy and
log an error if it's non-zero.
---
src/sbbs3/ftpsrvr.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/sbbs3/ftpsrvr.c b/src/sbbs3/ftpsrvr.c
index 0e0857df95..e9acc4c078 100644
--- a/src/sbbs3/ftpsrvr.c
+++ b/src/sbbs3/ftpsrvr.c
@@ -4891,7 +4891,11 @@ void DLLCALL ftp_server(void* arg)
else
SAFECOPY(scfg.temp_dir,"../temp");
prep_dir(scfg.ctrl_dir, scfg.temp_dir, sizeof(scfg.temp_dir));
- MKDIR(scfg.temp_dir);
+ if(!isdir(scfg.temp_dir) && MKDIR(scfg.temp_dir) != 0) {
+ lprintf(LOG_ERR, "Error %d creating temp directory: %s", errno, scfg.temp_dir);
+ cleanup(1,__LINE__);
+ break;
+ }
lprintf(LOG_DEBUG,"Temporary file directory: %s", scfg.temp_dir);
if(!isdir(scfg.temp_dir)) {
lprintf(LOG_CRIT,"!Invalid temp directory: %s", scfg.temp_dir);
--
GitLab