From 82dc340943ae9481b08a386a5f32ed1a0d4491fe Mon Sep 17 00:00:00 2001
From: deuce <>
Date: Wed, 14 Mar 2018 23:41:11 +0000
Subject: [PATCH] Copy the comment about VER Internet Rex 2.29 Win32
 (binkp/1.1) to where the challenge length is set and add a TODO comment
 there.

---
 exec/load/binkp.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/exec/load/binkp.js b/exec/load/binkp.js
index e816ba93e9..1fb38c3df8 100644
--- a/exec/load/binkp.js
+++ b/exec/load/binkp.js
@@ -79,6 +79,8 @@ function BinkP(name_ver, inbound, rx_callback, tx_callback)
 	this.sent_nr = false;
 	this.ver1_1 = false;
 	this.require_md5 = true;
+	// IREX VER Internet Rex 2.29 Win32 (binkp/1.1) doesn't work with longer challenges
+	// TODO: Remove this knob
 	this.cram_challenge_length = 16;
 	this.require_crypt = true;
 	this.timeout = 120;
@@ -529,7 +531,7 @@ BinkP.prototype.accept = function(sock, auth_cb)
 	if (this.sock == undefined || !this.sock.is_connected)
 		return false;
 
-	// IREX VER Internet Rex 2.29 Win32 (binkp/1.1) doesn't work with longer challenges
+	// IREX VER Internet Rex 2.29 Win32 (binkp/1.1) doesn't work with challenges longer than 32 chars
 	for (i=0; i < this.cram_challenge_length * 2; i++)
 		challenge += random(16).toString(16);
 
-- 
GitLab