From 891923f8bff85a63ea3eb6fbefdefc6595304111 Mon Sep 17 00:00:00 2001 From: Rob Swindell <rob@synchro.net> Date: Sun, 27 Dec 2020 18:07:46 -0800 Subject: [PATCH] Mention "use strict" for JS files. And avoid using unnecessary libraries. --- CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f591403df1..1c2137a7c8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,6 +16,10 @@ When modifying the C/C++ source files: * Do not call functions from `ctype.h` (e.g. `isprint()`, `isspace()`, `isdigit()`, etc.) - use the `xpdev/gen_defs.h IS_*` macros instead. * Use safe string handling (e.g. xpdev's `SAFECOPY()` instead of `strcpy()`, `SAFEPRINTF()` or `safe_snprintf()` instead of `sprintf()`). +When modifying JavaScript (`.js`) files: +* Specify `"use strict"` when adding new files and write conforming code +* Don't introduce/use 3rd party libraries unnecessarily + ### Branches Only approved and authenticaed "developers" can create new branches in the `main/sbbs`repo. If, as a developer, you are creating a new branch in the `main/sbbs` repository, use the branch naming scheme: `<your-name>/<topic>`, where *your-name* is your abbreviated name, user-name, or alias and *topic* helps to identify the intended purpose of the branch. Branches created in user repositories (e.g. forks of main/sbbs) need not contain the `<your-name>/` prefix. @@ -26,4 +30,4 @@ Only approved and authenticaed "developers" can create new branches in the `main ### Other types of contributions If you were interested in contributing money, not code, then paypal to rob at synchro dot net. -Thank you for contributing! \ No newline at end of file +Thank you for contributing! -- GitLab