Skip to content
Snippets Groups Projects
Commit a068d469 authored by Deucе's avatar Deucе :ok_hand_tone4:
Browse files

Ok, it's weird for the _upload() function to close the stream.

Make the one who opens it responsible for closing it.
parent a7e0c88c
No related branches found
No related tags found
No related merge requests found
Pipeline #7748 passed
......@@ -14932,9 +14932,8 @@ do_rip_command(int level, int sublevel, int cmd, const char *rawargs)
case 7:
zmodem_upload(rip.bbs, fp, cache_path);
break;
default: // Can't happen, thanks Coverity
fclose(fp);
}
fclose(fp);
suspend_rip(false);
free(uldir);
}
......@@ -1046,11 +1046,9 @@ begin_upload(struct bbslist *bbs, bool autozm, int lastch)
case 5:
raw_upload(fp);
break;
default:
fclose(fp);
break;
}
}
fclose(fp);
suspend_rip(false);
uifcbail();
restorescreen(savscrn);
......@@ -1156,7 +1154,6 @@ raw_upload(FILE *fp)
if (r == 0)
break;
}
fclose(fp);
}
void
......@@ -1197,7 +1194,6 @@ ascii_upload(FILE *fp)
cterm_write(cterm, ch, 1, NULL, 0, NULL);
}
}
fclose(fp);
}
static void
......@@ -1269,8 +1265,6 @@ zmodem_upload(struct bbslist *bbs, FILE *fp, char *path)
/* ZRQINIT? */ true, /* start_time */ NULL, /* sent_bytes */ NULL)) == true)
zmodem_get_zfin(&zm);
fclose(fp);
transfer_complete(success, was_binary);
}
......@@ -1664,7 +1658,6 @@ xmodem_upload(struct bbslist *bbs, FILE *fp, char *path, long mode, int lastch)
path, fsize / 1024, (mode & GMODE) ? "-g" : "");
}
else {
fclose(fp);
if (!was_binary)
conn_binary_mode_off();
return;
......@@ -1685,8 +1678,6 @@ xmodem_upload(struct bbslist *bbs, FILE *fp, char *path, long mode, int lastch)
}
}
fclose(fp);
transfer_complete(success, was_binary);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment