From a25a81310d1a27e01734cd2cc0bb20e92dd49c2d Mon Sep 17 00:00:00 2001
From: deuce <>
Date: Fri, 15 Jan 2016 12:26:27 +0000
Subject: [PATCH] Don't default the password to '-' when reading binkit.ini.
 Treat a password of '-' the same as an undefined password in binkit.js.

---
 exec/binkit.js       | 2 +-
 exec/load/fidocfg.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/exec/binkit.js b/exec/binkit.js
index 68e74ea7f4..a7c6c559a1 100644
--- a/exec/binkit.js
+++ b/exec/binkit.js
@@ -195,7 +195,7 @@ function callout_auth_cb(mode, bp)
 	 */
 	var addrs = [];
 
-	if (bp.cb_data.binkitpw === undefined)
+	if (bp.cb_data.binkitpw === undefined || bp.cb_data.binkitpw === '-')
 		addrs.push(bp.binkit_to_addr);
 	else {
 		bp.remote_addrs.forEach(function(addr) {
diff --git a/exec/load/fidocfg.js b/exec/load/fidocfg.js
index 58f5242381..67552b6421 100644
--- a/exec/load/fidocfg.js
+++ b/exec/load/fidocfg.js
@@ -321,7 +321,7 @@ function BinkITCfg()
 			var sec = section.toLowerCase();
 
 			this.node[sec] = {};
-			this.node[sec].pass = f.iniGetValue(section, 'Password', '-');
+			this.node[sec].pass = f.iniGetValue(section, 'Password');
 			this.node[sec].nomd5 = f.iniGetValue(section, 'AllowPlainPassword');
 			this.node[sec].port = f.iniGetValue(section, 'Port');
 			if (this.node[sec].nomd5 == undefined)
-- 
GitLab