<DigitalMan> Deuce: you're freeing str before converting it to a JSVAL

acdb95f3 · deuce · bb44e9c0 · acdb95f3
Commit acdb95f3 authored May 10, 2013 by deuce
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

src/sbbs3/js_uifc.c src/sbbs3/js_uifc.c +2 -2

No files found.
--- a/src/sbbs3/js_uifc.c
+++ b/src/sbbs3/js_uifc.c
@@ -485,11 +485,11 @@ js_uifc_input(JSContext *cx, uintN argc, jsval *arglist)
 	}
 	if(prompt)
 		free(prompt);
-	if(str)
-		free(str);
 	JS_RESUMEREQUEST(cx, rc);

 	JS_SET_RVAL(cx, arglist, STRING_TO_JSVAL(JS_NewStringCopyZ(cx,str)));
+	if(str)
+		free(str);

 	return(JS_TRUE);
 }