From b869bf8ca721367548be301da433c140b5529fbf Mon Sep 17 00:00:00 2001
From: "Rob Swindell (on ChromeOS)" <rob@synchro.net>
Date: Sat, 25 Mar 2023 18:35:20 -0700
Subject: [PATCH] Fix strListCmp() - apparently never tested
This function is used in sbbs_ini.c, but was always returnning non-zero, even
when both string lists were identical.
---
src/xpdev/str_list.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/xpdev/str_list.c b/src/xpdev/str_list.c
index 51e37b03db..e91cc3162a 100644
--- a/src/xpdev/str_list.c
+++ b/src/xpdev/str_list.c
@@ -590,8 +590,7 @@ int strListCmp(str_list_t list1, str_list_t list2)
strListSortAlphaCase(l1);
strListSortAlphaCase(l2);
- for(; *l1; l1++) {
- l2++;
+ for(; *l1; l1++, l2++) {
if(*l2==NULL) {
ret=1;
goto early_return;
@@ -602,7 +601,6 @@ int strListCmp(str_list_t list1, str_list_t list2)
goto early_return;
}
}
- l2++;
if(*l2==NULL)
ret=0;
else
--
GitLab