From b94cba8c1d1693c14bfafeb55ee276a5ac7a4634 Mon Sep 17 00:00:00 2001 From: Eric Oulashin <eric.oulashin@gmail.com> Date: Sat, 11 Jun 2022 13:31:29 -0700 Subject: [PATCH] DD message area chooser: Updated to try to prevent the error "this.subBoardListPrintfInfo[pGrpIdx] is undefined" when only choosing a sub-board within the user's current message group. --- xtrn/DDAreaChoosers/DDMsgAreaChooser.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/xtrn/DDAreaChoosers/DDMsgAreaChooser.js b/xtrn/DDAreaChoosers/DDMsgAreaChooser.js index 64c6ed5a35..2574f5c12e 100644 --- a/xtrn/DDAreaChoosers/DDMsgAreaChooser.js +++ b/xtrn/DDAreaChoosers/DDMsgAreaChooser.js @@ -34,7 +34,7 @@ * the sub-board list when using the lightbar menu * 2022-06-11 Eric Oulashin Version 1.26 * Updated to try to prevent the error "this.subBoardListPrintfInfo[pGrpIdx] is undefined" - * in CreateLightbarSubBoardMenu() + * when only choosing a sub-board within the user's current message group. */ // TODO: In the area list, the 10,000ths digit (for # posts) is in a different color) @@ -155,7 +155,9 @@ if (executeThisScript) // here just in case, and change the user's message area // here. Otherwise, if choosing the message group first, // SelectMsgArea() will change the user's sub-board. - var msgGroupIdx = (gChooseMsgGrpOnStartup ? 0/*null*/ : bbs.curgrp); + var msgGroupIdx = (gChooseMsgGrpOnStartup ? 0/*null*/ : +bbs.curgrp); + if (!gChooseMsgGrpOnStartup) + msgAreaChooser.BuildSubBoardPrintfInfoForGrp(msgGroupIdx); var chosenIdx = msgAreaChooser.SelectMsgArea(gChooseMsgGrpOnStartup, msgGroupIdx); if (!gChooseMsgGrpOnStartup && (typeof(chosenIdx) === "number")) bbs.cursub_code = msg_area.grp_list[bbs.curgrp].sub_list[chosenIdx].code; @@ -2057,9 +2059,6 @@ function DDMsgAreaChooser_GetMsgSubBrdLine(pGrpIndex, pSubIndex, pHighlight) numMsgs); } msgBase.close(); - - // Free some memory? - delete msgBase; } return subBoardLine; -- GitLab