From c016203c3e35c4a4d18c38a331b1659cc7df130d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Deuc=D0=B5?= <shurd@sasktel.net> Date: Sat, 4 Jan 2025 04:00:09 -0500 Subject: [PATCH] Give up on making Coverity happy. This code is fine. --- src/syncterm/modem.c | 2 +- src/syncterm/rlogin.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/syncterm/modem.c b/src/syncterm/modem.c index d4a2a7bb6b..553a185355 100644 --- a/src/syncterm/modem.c +++ b/src/syncterm/modem.c @@ -87,7 +87,7 @@ modem_output_thread(void *args) sent = 0; while (com != COM_HANDLE_INVALID && sent < wr && !conn_api.terminate) { ret = comWriteBuf(com, conn_api.wr_buf + sent, wr - sent); - if (ret > 0 && ret <= (wr - sent)) + if (ret > 0) sent += ret; if (ret < 0) break; diff --git a/src/syncterm/rlogin.c b/src/syncterm/rlogin.c index ffffd2408f..56674b03ab 100644 --- a/src/syncterm/rlogin.c +++ b/src/syncterm/rlogin.c @@ -65,7 +65,7 @@ rlogin_output_thread(void *args) while (rlogin_sock != INVALID_SOCKET && sent < wr && !conn_api.terminate) { if (socket_writable(rlogin_sock, 100)) { ret = sendsocket(rlogin_sock, conn_api.wr_buf + sent, wr - sent); - if (ret > 0 && ret <= (wr - sent)) + if (ret > 0) sent += ret; if (ret < 0) break; -- GitLab