From c14cea13c153d2e18455823fccedca57f5daac0a Mon Sep 17 00:00:00 2001
From: "Rob Swindell (on Windows 11)" <rob@synchro.net>
Date: Sat, 7 Dec 2024 14:03:53 -0800
Subject: [PATCH] A differnt 'fix' to link_area()
So, (sizeof *addr) now looks right got me (this should've been the same as
sizeof(fidoaddr_t)), so the change in commit e2476ebbaa doesn't actually look
like a fix, but maybee a regression.
I need to test some area manager link additions and get to the bottom of this,
but this particular change was not a fix (and caught/reported by Coverity -
CID 515673).
---
src/sbbs3/sbbsecho.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sbbs3/sbbsecho.c b/src/sbbs3/sbbsecho.c
index baf4d5a456..5c41e5d519 100644
--- a/src/sbbs3/sbbsecho.c
+++ b/src/sbbs3/sbbsecho.c
@@ -1306,7 +1306,7 @@ bool area_is_linked(unsigned area_num, const fidoaddr_t* addr)
void link_area(unsigned area_num, const fidoaddr_t* addr)
{
area_t* area = &cfg.area[area_num];
- if((area->link = realloc_or_free(area->link, (sizeof addr) * (area->links + 1))) == NULL) {
+ if((area->link = realloc_or_free(area->link, sizeof(fidoaddr_t) * (area->links + 1))) == NULL) {
lprintf(LOG_ERR,"ERROR line %d allocating memory for area "
"#%u links.",__LINE__, area_num + 1);
bail(1);
--
GitLab