From c71b13610e15eab6d39ec4e8901541be020e4fb3 Mon Sep 17 00:00:00 2001
From: rswindell <>
Date: Tue, 30 Aug 2011 22:51:21 +0000
Subject: [PATCH] Added 3 new header fields for tracing the originator (sender)
of messages, especially through SMTP (where these values are exposed via the
Originator-info header field): SENDERUSERID, SENDERSERVER, and SERVERTIME.
---
src/sbbs3/bulkmail.cpp | 4 ++--
src/sbbs3/email.cpp | 1 +
src/sbbs3/js_msgbase.c | 2 +-
src/sbbs3/mailsrvr.c | 13 ++++++++-----
src/sbbs3/netmail.cpp | 2 ++
src/sbbs3/postmsg.cpp | 14 ++++++++++++--
src/sbbs3/sbbs.h | 2 +-
src/sbbs3/writemsg.cpp | 1 +
8 files changed, 28 insertions(+), 11 deletions(-)
diff --git a/src/sbbs3/bulkmail.cpp b/src/sbbs3/bulkmail.cpp
index 45300a70fc..c6184cafe5 100644
--- a/src/sbbs3/bulkmail.cpp
+++ b/src/sbbs3/bulkmail.cpp
@@ -8,7 +8,7 @@
* @format.tab-size 4 (Plain Text/Source Code File Header) *
* @format.use-tabs true (see http://www.synchro.net/ptsc_hdr.html) *
* *
- * Copyright 2010 Rob Swindell - http://www.synchro.net/copyright.html *
+ * Copyright 2011 Rob Swindell - http://www.synchro.net/copyright.html *
* *
* This program is free software; you can redistribute it and/or *
* modify it under the terms of the GNU General Public License *
@@ -110,7 +110,7 @@ bool sbbs_t::bulkmail(uchar *ar)
memset(&smb,0,sizeof(smb));
smb.subnum=INVALID_SUB; /* mail database */
- i=savemsg(&cfg, &smb, &msg, &client, msgbuf);
+ i=savemsg(&cfg, &smb, &msg, &client, startup->host_name, msgbuf);
free(msgbuf);
if(i!=0) {
smb_close(&smb);
diff --git a/src/sbbs3/email.cpp b/src/sbbs3/email.cpp
index 9b15e1dd6e..785d0019a7 100644
--- a/src/sbbs3/email.cpp
+++ b/src/sbbs3/email.cpp
@@ -306,6 +306,7 @@ bool sbbs_t::email(int usernumber, const char *top, const char *subj, long mode)
/* Security logging */
msg_client_hfields(&msg,&client);
+ smb_hfield_str(&msg,SENDERSERVER,startup->host_name);
smb_hfield_str(&msg,SUBJECT,title);
diff --git a/src/sbbs3/js_msgbase.c b/src/sbbs3/js_msgbase.c
index 82185eb5cf..f658aa722e 100644
--- a/src/sbbs3/js_msgbase.c
+++ b/src/sbbs3/js_msgbase.c
@@ -1517,7 +1517,7 @@ js_save_msg(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
if(body[0])
truncsp(body);
- if((p->status=savemsg(scfg, &(p->smb), &msg, client, body))==SMB_SUCCESS) {
+ if((p->status=savemsg(scfg, &(p->smb), &msg, client, /* ToDo server hostname: */NULL, body))==SMB_SUCCESS) {
*rval = JSVAL_TRUE;
if(rcpt_list!=NULL) { /* Sending to a list of recipients */
diff --git a/src/sbbs3/mailsrvr.c b/src/sbbs3/mailsrvr.c
index a08a9e56ea..92ff5ac338 100644
--- a/src/sbbs3/mailsrvr.c
+++ b/src/sbbs3/mailsrvr.c
@@ -558,13 +558,16 @@ static ulong sockmimetext(SOCKET socket, smbmsg_t* msg, char* msgtxt, ulong maxl
if(!sockprintf(socket,"In-Reply-To: %s",msg->reply_id))
return(0);
- /* non-standard, but documented in draft-newman-msgheader-originfo-05 */
- sockprintf(socket,"Originator-Info: account=%s; ip-address=%s; hostname=%s; protocol=%s; port=%s"
+ /* non-standard, but documented (mostly) in draft-newman-msgheader-originfo-05 */
+ sockprintf(socket,"Originator-Info: account=%s; login-id=%s; server=%s; client=%s; addr=%s; prot=%s; port=%s; time=%s"
,msg->from_ext
- ,smb_get_hfield(msg,SENDERIPADDR,NULL)
+ ,smb_get_hfield(msg,SENDERUSERID,NULL)
+ ,smb_get_hfield(msg,SENDERSERVER,NULL)
,smb_get_hfield(msg,SENDERHOSTNAME,NULL)
+ ,smb_get_hfield(msg,SENDERIPADDR,NULL)
,smb_get_hfield(msg,SENDERPROTOCOL,NULL)
,smb_get_hfield(msg,SENDERPORT,NULL)
+ ,smb_get_hfield(msg,SENDERTIME,NULL)
);
for(i=0;i<msg->total_hfields;i++) {
@@ -2881,7 +2884,7 @@ static void smtp_thread(void* arg)
smb_hfield_str(&msg, RECIPIENT, rcpt_name);
smb.subnum=subnum;
- if((i=savemsg(&scfg, &smb, &msg, &client, msgbuf))!=SMB_SUCCESS) {
+ if((i=savemsg(&scfg, &smb, &msg, &client, startup->host_name, msgbuf))!=SMB_SUCCESS) {
lprintf(LOG_WARNING,"%04d !SMTP ERROR %d (%s) saving message"
,socket,i,smb.last_error);
sockprintf(socket, "452 ERROR %d (%s) saving message"
@@ -2983,7 +2986,7 @@ static void smtp_thread(void* arg)
/* E-mail */
smb.subnum=INVALID_SUB;
/* creates message data, but no header or index records (since msg.to==NULL) */
- i=savemsg(&scfg, &smb, &msg, &client, msgbuf);
+ i=savemsg(&scfg, &smb, &msg, &client, startup->host_name, msgbuf);
free(msgbuf);
if(i!=SMB_SUCCESS) {
smb_close(&smb);
diff --git a/src/sbbs3/netmail.cpp b/src/sbbs3/netmail.cpp
index 4dd7e54707..d919ef010b 100644
--- a/src/sbbs3/netmail.cpp
+++ b/src/sbbs3/netmail.cpp
@@ -256,6 +256,7 @@ bool sbbs_t::inetmail(const char *into, const char *subj, long mode)
/* Security logging */
msg_client_hfields(&msg,&client);
+ smb_hfield_str(&msg,SENDERSERVER,startup->host_name);
smb_hfield_str(&msg,SUBJECT,title);
@@ -463,6 +464,7 @@ bool sbbs_t::qnetmail(const char *into, const char *subj, long mode)
/* Security logging */
msg_client_hfields(&msg,&client);
+ smb_hfield_str(&msg,SENDERSERVER,startup->host_name);
smb_hfield_str(&msg,SUBJECT,title);
diff --git a/src/sbbs3/postmsg.cpp b/src/sbbs3/postmsg.cpp
index fe79e8a9b0..f609a0fa2d 100644
--- a/src/sbbs3/postmsg.cpp
+++ b/src/sbbs3/postmsg.cpp
@@ -344,6 +344,7 @@ bool sbbs_t::postmsg(uint subnum, smbmsg_t *remsg, long wm_mode)
/* Security logging */
msg_client_hfields(&msg,&client);
+ smb_hfield_str(&msg,SENDERSERVER,startup->host_name);
smb_hfield_str(&msg,SUBJECT,title);
@@ -409,21 +410,28 @@ extern "C" int DLLCALL msg_client_hfields(smbmsg_t* msg, client_t* client)
{
int i;
char port[16];
+ char date[64];
if(client==NULL)
return(-1);
+ if(client->user!=NULL && (i=smb_hfield_str(msg,SENDERUSERID,client->user))!=SMB_SUCCESS)
+ return(i);
+ if((i=smb_hfield_str(msg,SENDERTIME,xpDateTime_to_isoDateTimeStr(gmtime_to_xpDateTime(client->time)
+ ,/* separators: */"","","", /* precision: */0
+ ,date,sizeof(date))))!=SMB_SUCCESS)
+ return(i);
if((i=smb_hfield_str(msg,SENDERIPADDR,client->addr))!=SMB_SUCCESS)
return(i);
if((i=smb_hfield_str(msg,SENDERHOSTNAME,client->host))!=SMB_SUCCESS)
return(i);
- if((i=smb_hfield_str(msg,SENDERPROTOCOL,client->protocol))!=SMB_SUCCESS)
+ if(client->protocol!=NULL && (i=smb_hfield_str(msg,SENDERPROTOCOL,client->protocol))!=SMB_SUCCESS)
return(i);
SAFEPRINTF(port,"%u",client->port);
return smb_hfield_str(msg,SENDERPORT,port);
}
-extern "C" int DLLCALL savemsg(scfg_t* cfg, smb_t* smb, smbmsg_t* msg, client_t* client, char* msgbuf)
+extern "C" int DLLCALL savemsg(scfg_t* cfg, smb_t* smb, smbmsg_t* msg, client_t* client, const char* server, char* msgbuf)
{
char pid[128];
char msg_id[256];
@@ -519,6 +527,8 @@ extern "C" int DLLCALL savemsg(scfg_t* cfg, smb_t* smb, smbmsg_t* msg, client_t*
if(client!=NULL)
msg_client_hfields(msg,client);
+ if(server!=NULL)
+ smb_hfield_str(msg,SENDERSERVER,server);
/* Generate RFC-822 Message-id */
if(msg->id==NULL) {
diff --git a/src/sbbs3/sbbs.h b/src/sbbs3/sbbs.h
index 6afa8aeefd..e9319c63fe 100644
--- a/src/sbbs3/sbbs.h
+++ b/src/sbbs3/sbbs.h
@@ -836,7 +836,7 @@ extern "C" {
DLLEXPORT void DLLCALL delfattach(scfg_t*, smbmsg_t*);
/* postmsg.cpp */
- DLLEXPORT int DLLCALL savemsg(scfg_t*, smb_t*, smbmsg_t*, client_t*, char* msgbuf);
+ DLLEXPORT int DLLCALL savemsg(scfg_t*, smb_t*, smbmsg_t*, client_t*, const char* server, char* msgbuf);
DLLEXPORT void DLLCALL signal_sub_sem(scfg_t*, uint subnum);
DLLEXPORT int DLLCALL msg_client_hfields(smbmsg_t*, client_t*);
DLLEXPORT char* DLLCALL msg_program_id(char* pid);
diff --git a/src/sbbs3/writemsg.cpp b/src/sbbs3/writemsg.cpp
index dbf20551b9..6e765ac40e 100644
--- a/src/sbbs3/writemsg.cpp
+++ b/src/sbbs3/writemsg.cpp
@@ -1146,6 +1146,7 @@ void sbbs_t::forwardmail(smbmsg_t *msg, int usernumber)
/* Security logging */
msg_client_hfields(msg,&client);
+ smb_hfield_str(msg,SENDERSERVER,startup->host_name);
username(&cfg,usernumber,touser);
smb_hfield_str(msg,RECIPIENT,touser);
--
GitLab