From cb1d932fc551ed2e59f5f6c992c90dfdab0e3963 Mon Sep 17 00:00:00 2001 From: deuce <> Date: Sat, 3 Nov 2018 05:45:27 +0000 Subject: [PATCH] Fix new error with Clang 6.x: exec.cpp:438:8: error: case value evaluates to 2684500526, which cannot be narrowed to type 'int32_t' (aka 'int') [-Wc++11-narrowing] case 0xA0023A2E: ^ The switch cases were unsigned, but the passed value was an int32. --- src/sbbs3/exec.cpp | 4 ++-- src/sbbs3/sbbs.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sbbs3/exec.cpp b/src/sbbs3/exec.cpp index 72de5d2956..b3437f1b8d 100644 --- a/src/sbbs3/exec.cpp +++ b/src/sbbs3/exec.cpp @@ -39,7 +39,7 @@ #include "cmdshell.h" #include "js_request.h" -char ** sbbs_t::getstrvar(csi_t *bin, int32_t name) +char ** sbbs_t::getstrvar(csi_t *bin, uint32_t name) { uint i; @@ -124,7 +124,7 @@ char ** sbbs_t::getstrvar(csi_t *bin, int32_t name) return((char **)&sysvar_p[sysvar_pi++]); } -int32_t * sbbs_t::getintvar(csi_t *bin, int32_t name) +int32_t * sbbs_t::getintvar(csi_t *bin, uint32_t name) { uint i; diff --git a/src/sbbs3/sbbs.h b/src/sbbs3/sbbs.h index 3cb8220e3c..17fdafd06b 100644 --- a/src/sbbs3/sbbs.h +++ b/src/sbbs3/sbbs.h @@ -569,8 +569,8 @@ public: long exec_bin(const char *mod, csi_t *csi, const char* startup_dir=NULL); void clearvars(csi_t *bin); void freevars(csi_t *bin); - char** getstrvar(csi_t *bin, int32_t name); - int32_t* getintvar(csi_t *bin, int32_t name); + char** getstrvar(csi_t *bin, uint32_t name); + int32_t* getintvar(csi_t *bin, uint32_t name); char* copystrvar(csi_t *csi, char *p, char *str); void skipto(csi_t *csi, uchar inst); bool ftp_cmd(csi_t* csi, SOCKET ctrl_sock, const char* cmdsrc, char* rsp); -- GitLab