From eb6e0f2078473afddc1df1cf4a6a43a2fa24019b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Deuc=D0=B5?= <shurd@sasktel.net>
Date: Fri, 9 Jun 2023 14:15:42 -0400
Subject: [PATCH] Some more Coverity shutupness
---
src/syncterm/conn.c | 3 ++-
src/syncterm/ssh.c | 3 ++-
src/syncterm/telnets.c | 3 ++-
src/syncterm/term.c | 6 ++++--
4 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/syncterm/conn.c b/src/syncterm/conn.c
index 712f133f9a..6f955259ce 100644
--- a/src/syncterm/conn.c
+++ b/src/syncterm/conn.c
@@ -575,7 +575,8 @@ connected:
ioctlsocket(sock, FIONBIO, &nonblock);
if (!socket_recvdone(sock, 0)) {
int keepalives = true;
- setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE, (void *)&keepalives, sizeof(keepalives));
+ if (setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE, (void *)&keepalives, sizeof(keepalives)))
+ fprintf(stderr, "%s:%d: Error %d calling setsockopt()\n", __FILE__, __LINE__, errno);
if (!bbs->hidepopups)
uifc.pop(NULL);
diff --git a/src/syncterm/ssh.c b/src/syncterm/ssh.c
index a1d3066db8..3d4edf9cdb 100644
--- a/src/syncterm/ssh.c
+++ b/src/syncterm/ssh.c
@@ -184,7 +184,8 @@ ssh_connect(struct bbslist *bbs)
}
/* we need to disable Nagle on the socket. */
- setsockopt(ssh_sock, IPPROTO_TCP, TCP_NODELAY, (char *)&off, sizeof(off));
+ if (setsockopt(ssh_sock, IPPROTO_TCP, TCP_NODELAY, (char *)&off, sizeof(off)))
+ fprintf(stderr, "%s:%d: Error %d calling setsockopt()\n", __FILE__, __LINE__, errno);
SAFECOPY(password, bbs->password);
SAFECOPY(username, bbs->user);
diff --git a/src/syncterm/telnets.c b/src/syncterm/telnets.c
index 99d87c5c23..5e57bed5c4 100644
--- a/src/syncterm/telnets.c
+++ b/src/syncterm/telnets.c
@@ -63,7 +63,8 @@ telnets_connect(struct bbslist *bbs)
}
/* we need to disable Nagle on the socket. */
- setsockopt(ssh_sock, IPPROTO_TCP, TCP_NODELAY, (char *)&off, sizeof(off));
+ if (setsockopt(ssh_sock, IPPROTO_TCP, TCP_NODELAY, (char *)&off, sizeof(off)))
+ fprintf(stderr, "%s:%d: Error %d calling setsockopt()\n", __FILE__, __LINE__, errno);
if (!bbs->hidepopups)
uifc.pop(NULL);
diff --git a/src/syncterm/term.c b/src/syncterm/term.c
index e684a90fa5..575632068a 100644
--- a/src/syncterm/term.c
+++ b/src/syncterm/term.c
@@ -2386,8 +2386,10 @@ get_cache_fn_subdir(struct bbslist *bbs, char *fn, size_t fnsz, const char *subd
return ret;
strcat(fn, subdir);
backslash(fn);
- if (!isdir(fn))
- mkpath(fn);
+ if (!isdir(fn)) {
+ if (mkpath(fn))
+ return 0;
+ }
if (!isdir(fn))
return 0;
return 1;
--
GitLab