From ee0e8e0a5d96037d2fea4642dd09f559d8d1cf56 Mon Sep 17 00:00:00 2001
From: Deuce <shurd@sasktel.net>
Date: Thu, 26 Nov 2020 02:08:45 -0500
Subject: [PATCH] Log warning when peer does not indicate binkp/1.1 correctly,
but we assume it's 1.1 anyway.
---
exec/load/binkp.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/exec/load/binkp.js b/exec/load/binkp.js
index b136a5af18..f367509dcc 100644
--- a/exec/load/binkp.js
+++ b/exec/load/binkp.js
@@ -1215,6 +1215,9 @@ BinkP.prototype.recvFrame = function(timeout)
this.remote_ver = m[1];
log(LOG_INFO, "Peer version: " + this.remote_ver);
binkp_ver = parseFloat(m[2].substr(m[2].indexOf('binkp/') + 6));
+ if (m[2] !== 'binkp/1.1' && binkp_ver > 1.0) {
+ log(LOG_WARNING, 'Peer ended their VER with " '+m[2]+'" instead of the required " binkp/1.1", but we\'re assuming binkp 1.1 anyway');
+ }
log(LOG_DEBUG, "Parsed BinkP version: " + binkp_ver);
this.ver_1_1 = binkp_ver >= 1.1;
}
--
GitLab