From f23316a0acd7ceacfddda03e8d954265a655147b Mon Sep 17 00:00:00 2001
From: rswindell <>
Date: Wed, 6 Mar 2002 21:51:40 +0000
Subject: [PATCH] Fixed buffer overflow bug in services JS log() method.
---
src/sbbs3/services.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sbbs3/services.c b/src/sbbs3/services.c
index d731a15174..b0d3c69a96 100644
--- a/src/sbbs3/services.c
+++ b/src/sbbs3/services.c
@@ -283,7 +283,7 @@ js_log(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
for(i=0;i<argc && strlen(str)<(sizeof(str)/2);i++) {
if((js_str=JS_ValueToString(cx, argv[i]))==NULL)
return(JS_FALSE);
- strcat(str,JS_GetStringBytes(js_str));
+ strncat(str,JS_GetStringBytes(js_str),sizeof(str)/2);
strcat(str," ");
}
--
GitLab