Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Fix for undefined bottomMsgIndex when going to a message in the lightbar list, and strict mode fixes

Graphic is now only used when using the scrollable interface. Also, when creating the Graphic, now subtracting 1 from the reading area height to avoid making the Graphic one line too tall to avoid unnecessary scrolling.
When saving messages with ANSI codes, Graphic is only used if the message has any ASCII drawing characters. (not sure if this really matters much though).
Also, applied "use strict" and made some changes as necessary.

DDMsgReader: When doing a text search, it now ignores the user scan configuration for sub-boards, to ensure it will show any results of the text search.

DDMsgReader Version 1.49 - Refactor: Simplified saving a message to BBS machine for sysop (as-is, less processing); removed attachment stuff for pre-Synchronet 3.17; moved hasSyncAttrCodes() to attr_conv.js because that's where it needs to be.

Now calls bbs.edit_msg() to edit an existing message (if that function exists - It
was added in Synchronet 3.18).

Added back a few functions that were accidentally removed (which weren't moved to attr_conv.js)

Fix: When changing to an empty sub-board from within the reader (either from
read mode or list mode), it now properly says there are no messages and exits,
rather than showing a list of bogus messages.
Unsure when this bug was introduced.
The version is now 1.46.

Fix for no group information available when displaying the sub-board header above the message list when listing personal email

Version 1.44:
Removed the scanScopePromptText text line and used the SubGroupOrAll line (621) from text.dat instead.  Also, the reader now supports @-code expansion in configured text strings.  This addresses issue #316 from Vincent Macaluso.
Text search now can search sub-board, group, or all like the other text searching (requested by Nelgin).
When reading the theme file, color settings are now checked to ensure they only have Synchronet attribute codes.

viewing message header info (I had used the same loop control variable name for a
loop inside a loop..oops).  Also, when viewing message header information, it will no
longer show JS functions.

Also, the first attempt at converting HTML entities in HTML-formatted messages (not working 100%).
Also, added the ability to sort the message list by date & time written rather than the import date/time.
This is specified in the configuration file via the msgListSort option.

user's current sub-board is a high-numbered sub-board and they select a message
group with fewer sub-boards, the highlighted sub-board in that group would be
set to that high number and would be incorrect.  That has been fixed.  Copied a
fix from my stand-alone message area chooser.  In that scenario, the current
highlighted sub-board in the other group will be the first one.

Eric Oulashin authored 4 years ago and Rob Swindell committed 4 years ago

When forwarding a message, it now correctly sets sets the to_net_type property in the
message header to FidoNet or internet for those types of message destinations

Version 1.37: Added mouse support to the scrollable reader interface.  The integrated area changer functionality doesn't have mouse support yet.

Version 1.36: Added a command-line parameter to DDMsgReader.js, -onlyNewPersonalEmail, which specifies to list/read only new/unread personal email to the user.  And for integration with Synchronet via the "Read Email" loadable module, this is to be used together with the updated DDReadPersonalEmail.js.  This is intended to support the "read your unread mail only" option in the email menu.

Version 1.35: Fixed some logic in determining how to address a personal email when replying (either to a local user or via their network address).

Version 1.34: The message list mode now honors anonymous posts, showing the 'from' name as "Anonymous" (for non-sysops).  The sysop can still see the real name of the poster.  The reader mode already honored the 'anonymous' flag.

Version 1.33 - Fixed: A new user starting to read messages in a sub-board no longer causes an error (it checks for the scan_ptr being 0xffffffff).  This had been fixed in a couple places previously, but apparently not this particular case.

Version 1.32: Removed some code that's no longer used.  Also, fixed an issue when changing to another sub-board with the traditional-style (non-lightbar) list where it was slow to list sub-boards.  For the number of messages, it was checking all headers to ignore ones marked as deleted, etc., but that can be fairly slow..  Now it just uses total_msgs for the MessageBase object, which is a lot faster and still gives an idea of how many messages are there.

The area change feature now uses DDLightbarMenu.  There is no more internal lightbar code in this message reader. This requires the latest dd_lightbar_menu.js (in sbbs/exec/load).

Version 1.30: The message list features now uses DDLightbarMenu rather than the internal lightbar menu code.  Requires the latest dd_lightbar_menu.js (in sbbs/exec/load).
Later I also plan to update the area chooser code to also use DDLightbarMenu and remove the internal lightbar chooser code from DDMsgReader altogether.

Version 1.29: When reading a message, if a message is written to the current user, the 'To' username in the header above the message is now written in a different color.  Also, there are new color settings available in the theme configuration file (see the readme for descriptions): msgHdrMsgNumColor, msgHdrFromColor, msgHdrToColor, msgHdrToUserColor, msgHdrSubjColor, msgHdrDateColor

Version 1.28 - Bug fix: When the user changes to a different message area while reading a message, the reader would exit with an error due to an invalid last-read message number.  This has been fixed.

Version 1.27 - Bug fix: Now displays the message score in the header even if the message only has downvotes

Version 1.26: Fixes a bug that was causing some of the message vote tally information to be displayed as "undefined"

Version 1.25: Added the ability to search for message groups and sub-boards when changing to another sub-board. Search can be started with the / key or CTRL-F (Find). Also, in lightbar mode, the N key can be used to highlight the next match in the list.

Version 1.24: When making a private reply on local email, an error is now outputted if the recipient's user number is not found.  Also, fixed an 'undefined' bug that happened when searching for messages sometimes.

Version 1.23: If a message is in UTF-8 format and the user's terminal doesn't support UTF-8, the message text will be converted to CP437.  Also, if there is a color/attribute code in the message before the message text and there are no other color/attribute codes, the color/attribute codes will be removed so  that the entire message isn't colored

Version 1.22: If the message score is 0, with upvotes and total_votes both 0, then don't show the score when using the default header ANSI.  This is what was intended, but the 0 score started showing up in more recent builds of Synchronet.

Version 1.21: Uses require() instead of load() to load the required .js libraries, if the require() function is defined (it was added in Synchronet 3.17).  This avoids 'multiple definition' errors with the latest .js libarries & Synchronet binaries.

Added configurable options for the message score colors for the message list: msgListScoreColor, msgListToUserScoreColor, msgListFromUserScoreColor, and msgListScoreHighlightColor.  Incremented version to 1.20.