1. 06 Oct, 2021 2 commits
    • Rob Swindell's avatar
      New @-codes SEX and GENDERS · 0e270c4e
      Rob Swindell authored
      SEX is the user's sex/gender
      GENDERS is the list of system-supported genders for new users to choose from.
    • Rob Swindell's avatar
      Don't append the stale static string in fmsgattr_str() · bb0d2496
      Rob Swindell authored
      When this function was called multiple times (e.g. multiple messages in a pkt),
      it would keep appending to the current (static) string, eventually overflowing
      the buffer and corrupting the stack. Although reported in pktdump, it could
      have also happened with fmsgdump if passed multiple stored message (.msg) files.
      Fixes #295 reported by Nelgin
  2. 05 Oct, 2021 3 commits
  3. 01 Oct, 2021 1 commit
    • Rob Swindell's avatar
      Rename the 40col menus from .asc to .msg so they appear for CBM/PETSCII terms · 87d52b24
      Rob Swindell authored
      The menu file selection priority is like this (for 40col CBM/PETSCII terminals):
      so the main.msg was being chosen before main.40col.asc.
      Plus, these files contain ex-ASCII chars, so .msg is actually the more correct
      file extension anyway.
  4. 25 Sep, 2021 4 commits
    • Rob Swindell's avatar
      EnterYourSex -> EnterYourGender · 6722f278
      Rob Swindell authored
      Uses new @code: GENDERS
      parts of enhancement #291
    • Rob Swindell's avatar
      Allow sysop to configure new user gender options (not just M/F) · 7638af10
      Rob Swindell authored
      Up to 40 characters can be configured by the sysop for gender options.
      The default choice/configuration is now: "M/F/X" (not just "M/F")
      New @-code: GENDERS
      text.dat EnterYourSex -> EnterYourGender
      Closes enhancement request #291 by Ragnarok
    • Rob Swindell's avatar
      Call smb_updatethread() from sbbs_t::email() to perform Keyop "magic" · aaa6fa7e
      Rob Swindell authored
      As discovered by Keyop and reported via IRC, when replying *to* a local mail box and *not* using the hard-coded email menu (e.g. when when using msglist.js), the original message's "Replied" attribute flag was not set. When replying to a netmail address (at least, Internet or FidoNet, unsure about QWKnetmail), the attribute would be set.
      This discrepancy was because this email() function doesn't use the  "modern" smb_addmsg() function (which also calls smb_updatethread()), but add the message body text the old/manual way and never called smb_updatethread(). smb_updatethread() does the thread linkage stuff (which is usually unnoticed in the mail base) *and* sets the "Replied" attribute of the original message, if it's not already set.
      This function should be overhauled to use smb_addmsg(), but this 2-line change at least addresses this issue for now. There's probably other places (e.g. importing mail replies via QWK/REP packets) where this thread-linkage and "Replied" attribute flag setting is still not happening.
    • Rob Swindell's avatar
      Added "Replied" attribute to mail messages that are replied-to. · 4e61b7ba
      Rob Swindell authored
      Reported by Keyop.
  5. 24 Sep, 2021 1 commit
  6. 23 Sep, 2021 2 commits
    • Rob Swindell's avatar
      When importing FidoNet message area tags > 40 chars, use newsgroup name · 095a7b4b
      Rob Swindell authored
      Follow-up to previous commit for Keyop (extending max area tag length from 35 to 40/50 chars), when importing echolists/areas.bbs files, if the area tag is longer than 40 chars, then import it into the newsgroup name field instead (63 chars max).
    • Rob Swindell's avatar
      Increase FidoNet echo/area tag max length from 35 to 40/50 chars · 8940bde7
      Rob Swindell authored
      Per FMail.txt:
      Area name
                This is the name of the conference. It can be up to 50
                characters long. This name is often referred to as the
                area tag.
      I did not locate a FidoNet spec to contradict that and support a 35 character maximum area tag length. I think Mystic also has a 50 character area tag limit. So 50 character area tags are fine I guess.
      So up to 50 characters are now supported in SBBSecho and SCFG for area tags (for message and file echoes). The exception is the (new to 3.19) optional area tag stored in msgs.cnf/file.cnf is limited to 40 characters due to reserved space limitations. If you need a tag stored per sub (most sysops do not) and it needs to be longer than 40 chars, use the newsgroup name instead (limited to 63 chars).
      Changed at the request of Keyop via IRC.
  7. 22 Sep, 2021 1 commit
  8. 21 Sep, 2021 1 commit
  9. 19 Sep, 2021 1 commit
  10. 18 Sep, 2021 1 commit
    • Rob Swindell's avatar
      Fix segfault reported with ftpalias.cfg support in some cases · bb1ee459
      Rob Swindell authored
      ftpalias() can return true even when the directory is not set to a valid
      directory index (i.e. set to -1), so using as an array index would definitely
      segfault. Part of commit 8ad30b6c by Deuce 3 years ago.
      I didn't test this as I'm not sure exactly the combination of ftpalias.cfg
      content and FTP command received that would trigger this, but it's most
      definitely a bug.
      So should fix the segfault reported in issue #288.
  11. 08 Sep, 2021 1 commit
  12. 07 Sep, 2021 2 commits
  13. 06 Sep, 2021 2 commits
    • Rob Swindell's avatar
      Change SearchExtendedQ to DisplayExtendedFileInfoQ · d6253952
      Rob Swindell authored
      Relates to feature request #285.
    • Rob Swindell's avatar
      When searching for text in file descriptions, always search ext desc · f0d253ef
      Rob Swindell authored
      Since users can (and usually do) display extended descriptions in their normal file listings anyway, it makes sense to go ahead and search them for the text (e.g. with the 'F' command from the default command shell File menu/prompt). So the "search/display extended info" prompt has been changed to just "Display extended file info" since it no longer controls whether or not the extended description is searched for the text (it always is). The FL_EXFIND was renamed to FL_EXT and only controls whether the extended info is display (the FL_FIND mode flag, always renamed, must also be specified for a find with extended info).
      This closes feature request #285 by Phil (@plt).
  14. 30 Aug, 2021 1 commit
  15. 24 Aug, 2021 1 commit
  16. 18 Aug, 2021 3 commits
  17. 15 Aug, 2021 1 commit
  18. 12 Aug, 2021 1 commit
  19. 10 Aug, 2021 1 commit
  20. 09 Aug, 2021 3 commits
  21. 05 Aug, 2021 1 commit
  22. 01 Aug, 2021 2 commits
    • Rob Swindell's avatar
      Allow text of all guest information prompts to be overridden in modopts.ini · e7579187
      Rob Swindell authored
      By setting guest_name, guest_email, guest_location, or guest_referral to any
      truthy value, a prompt will be display. By setting it to a string (instead of
      true), that string will be displayed. I'm not sure how I feel about this kind
      of tri-state setting (true/false/string), but it does reduce the number of
      settings/options. The alternative is to have a separate boolean and string
      setting for each prompt (which I first considered).
      So, as of now:
      guest_name = false <- no prompt for Guest's name
      guest_name = "" <- no prompt for Guest's name
      guest_name = true (the default) <- default prompt text for Guest's name
      guest_name = "Enter your name, dude" <- replaces prompt text for Guest's name
      For enter trailing white-space and ctrl-a codes, use string literals, e.g.
      guest_name: "\x01hEnter your name, dude: "
    • Rob Swindell's avatar
      Guest user prompts can be disabled via modopts.ini [logon] settings · 491228fe
      Rob Swindell authored
      guest_name = false will disable name prompt
      guest_email = false will disable the email address prompt
      guest_location = false will disable the location prompt
      guest_referral = false will disable the "where'd you hear about this BBS" prompt
      Note, at minimum, I do recommend prompting for the guest's email address so that if they send the sysop feedback (e.g. ask a question), they at least have some hope of receiving a reply.
  23. 31 Jul, 2021 3 commits
  24. 12 Jul, 2021 1 commit