GitLab

5 options:
- Safest Subset
- Most ASCII, Excluding Spaces (the default)
- Most ASCII, Including Spaces
- Most CP437, Excluding Spaces
- Most CP437, Including Spaces

sbbs_t::checkfname() now checks the file.can too.
new filedat.c functions:
- safest_filename() - not currently used
- illegal_filename() - returns true for a highly-suspicious (e.g. hack attempt) filename
- allowed_filename() - returns true if the filename is good for upload (assumed to be already checked to be legal as well).

Importantly, filenames beginning or ending in a '.' are now unallowed:
- 'dot files' are hidden (by default) on *nix
- files ending in a '.' are problematic on Windows

This has the effect of the file being listed as absent/deleted in the listing that's in memory. As requested by Phil, plt via irc.

Moving a file after this change did result in a crash once, but I couldn't reproduce it with a debugger attached.

New text.dat string:
- EditExtDescriptionQ

Removed text.dat string:
DeleteExtDescriptionQ

If the file doesn't already have a description, f->desc may be NULL.
Remove the redundant user name in the "removed file" log message.

CID 331582

by adding a 'clear' argument to msgabort() that defaults to false. Pass true to check-and-clear.
checkline() is a NO-OP, so start eliminating "calls" to it.

... upon console abort (Ctrl-C).

Now, just 'E', then 'D' from the batch flag prompt has you editing a file description - rather than going through all the prompts for uploader name/date, etc.

Added text.dat string FileInfoEditPrompt.

Does not allow rename of file from this prompt - perhaps it should?

Resolves issue #263.

e.g. file.cpp line 239 (removefile) removing "filename.zip" access=-203 info=smb_freemsgdat reading allocation record at offset 1108

Also, if there is an error removing the original file from the filebase, don't proceed to move the actual file (and log a successful move).

Inspired by Blocktronics (and other ANSI art group) packs' FILE_ID.DIZ/ANS files:
* Support (and prioritize) FILE_ID.ANS
* Convert ANSI color/attribute sequences in DIZ files to Ctrl-A equivalent (uses SAUCE width and ICE color, if specified)
* Don't treat DIZ as a series of lines, they're not always nowadays.
* New putmsg() mode: P_INDENT to print files indented by current column
* Display full (up to 64-char) filenames in lists when using 132+ column terminal.
* Use the Author, Group, and Title fields from the SAUCE if present/non-blank
* 2 new text.dat strings: 301 (FiAuthor) and 302 (FiGroup)
* Also fix bug with repeated Cost header field on bulk-uploaded files.

I know this'll break the *nix build (sauce.c dependency), but I'll fix that next.

for the user-to-user file transfer directory

Good catch Coverity (CID 330974).

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

(not delete) from the end of the sorted list of files (normally, 0).
Created an sbbs_t::delfiles() wrapper which defaults to keep 0 files and also
generates a error.log message if any of the file-deletions fail.

output. Example:
File size        : 7,128,414 (6.8M) bytes

- FILE_AREA
- FILE_AREA_DESC
- FILE_LIB
- FILE_LIB_DESC
- FILE_LIB_NUM
- FILE_DIR
- FILE_DIR_DESC
- FILE_DIR_CODE
- FILE_DIR_NUM
- FILE_NAME
- FILE_DESC
- FILE_UPLOADER
- FILE_SIZE
- FILE_CREDITS
- FILE_TIME
- FILE_TIME_ULED
- FILE_TIME_DLED
- FILE_DATE
- FILE_DATE_ULED
- FILE_DAT_DLED
- FILE_TIMES_DLED
Fixed MSG_ATTR @-code (missing SPAM attribute)
New text.dat line: FileHdrDescSeparator, displayed between file detail display
(name, date, uploader, etc.) and extended description, if there is one. This
is used to execute showfileavatar.js.
New JS 'bbs' object properties:
- file_name
- file_description
- file_dir_number
- file_attr
- file_date
- file_credits
- file_uploader
- file_update_date
- file_download_date
- file_download_count
Inspiried by Lon Seidman's now infamous (but likely common) Synchronet sysop
blunder (removing a file rather than downloading it while demonstrating his BBS
on his youtube channel:
- New text.dat line: RemoveFileQ <- using this rather than the vague:
  AreYouSureQ, when prompting to remove a file
- The sysop command to remove files from the batch file flagging prompt has
  been changed from 'D' (delete) to 'R' (remove).
- The 'D' command from the batch file flagging prompt may now be used for
  immediate Download of any flagged file(s).
- When flagging files with '*', treat the same as '*.*'

other things to detect/display the actual filename (when different than
what's stored in the database).

time (e.g. "00:00:00"). Synchronet v3 has always forced this value to 0 since
it's inaccurate over TCP/IP with the current hard-coded "CPS" rate of 3000
(i.e. bytes-per-second).

longer (use lprintf(LOG_ERR,...) instead, which does).
Added sbbs_t::hacklog() for convenience.

inserting (long) typedefs to prevent warnings, but in the case of the JS File()
class, actually supporting file lengths > 32-bit.

by properly const-ifying the appropriate functions and variables.

Not yet tested on Win32

Remove time32str()

chars (probably overkill).
checkfname() now rejects filenames begining with a dash as a "suspicious
filename".