1. 10 Jun, 2021 3 commits
    • Rob Swindell's avatar
      Standardize on "metadata" as the description of a file's "tail" dfield · 3549be9f
      Rob Swindell authored
      It's anticipated that this will be used for JS-populated file metadata in JSON format in the future (and not just "archive contents" in .ini format).
      
      Also, fix the double-free issue that was occurring when moving files with extended file descriptions (sbbs_t::movefile()). This was actually the primary problem I was fixing here, but noticed the metadata issue: metadata would not have been moved along with the other file info between bases.
      3549be9f
    • Rob Swindell's avatar
      mv() simplified for the non-copy case · 80422644
      Rob Swindell authored
      Constified function arguments. Source path is still case-insensitive, but destination is case-sensitive (hopefully that's not an issue).
      
      When a "move" (!copy) is requested, a rename() is always attempted first and if successful, job done. Otherwise, we continue on with the file-copy (and then remove).
      
      This should resolve CID 332219 (DEADCODE).
      80422644
    • Rob Swindell's avatar
      Call smb_freefilemem() instead of smb_msgmem() for files · 0c5c140e
      Rob Swindell authored
      Not that it really matters, but perhaps it'll matter in the future. And the code reads better.
      0c5c140e
  2. 09 Jun, 2021 6 commits
  3. 08 Jun, 2021 10 commits
  4. 07 Jun, 2021 2 commits
    • Rob Swindell's avatar
      Modernize finduser() a bit · 2106e629
      Rob Swindell authored
      Skip any prepended white-space in the passed name to find.
      Use better variable names (and length) for the character strings.
      Use matchusername() instead of strcmp(); matchusername() follows the liberal user-id/alias/name matching algorithm.
      Use strcasestr() instead of strstr(), so no copy/modification (upper-casing) of passed name is now required.
      When 'Q'uitting the search, set the SS_ABORT flag.
      2106e629
    • Rob Swindell's avatar
      4415d99b
  5. 06 Jun, 2021 17 commits
  6. 05 Jun, 2021 2 commits
    • Rob Swindell's avatar
      Add new commands to flag/unflag all messages for deletion · d653a6d9
      Rob Swindell authored
      The command to delete and remove all messages is changed from 'd' to 'D'.
      This operation is not reversable.
      
      New commands are 'd' (flag all msgs for deletion) and 'u' (undelete all msgs).
      d653a6d9
    • Rob Swindell's avatar
      Don't allow colons in web-requested path names on Windows · a487e0c6
      Rob Swindell authored
      This fixes issue #269 (NTFS Alternate Data Stream vulnerability) and other
      potential pathname issues on Windows involving colons.
      
      There are other illegal filename characters on Windows (e.g. <>|"?*), but
      filenames with these characters aren't expected to pass the later stat() test,
      so should fail with a 404 error.
      a487e0c6