GitLab

It's anticipated that this will be used for JS-populated file metadata in JSON format in the future (and not just "archive contents" in .ini format).

Also, fix the double-free issue that was occurring when moving files with extended file descriptions (sbbs_t::movefile()). This was actually the primary problem I was fixing here, but noticed the metadata issue: metadata would not have been moved along with the other file info between bases.

And the "name not found" error text was wrong.

Don't allocate and memset a buffer of -1:
#1  0x0000559222bc167f in strListCombine (list=0x559224220720, buf=0x559224226550 "", maxlen=18446744073709551615,
    delimit=0x559222bcce0a "\r\n") at str_list.c:447
447             memset(buf, 0, maxlen);
(gdb) print maxlen
$1 = 18446744073709551615
(gdb) up
#2  0x0000559222ba3841 in smb_addfile_withlist (smb=0x7ffce63a7e90, file=0x7ffce63a5bc0, storage=1, extdesc=0x0,
    list=0x559224220720, path=0x7ffce63a6e80 "/xfer/loons/manhater.mp3") at smbfile.c:365
365                     strListCombine(list, content, size - 1, "\r\n");
(gdb) print list
$2 = (str_list_t) 0x559224220720
(gdb) print list[0]
$3 = 0x0

Found/reported by plt via irc. Thanks!

This will allow fast/easy display of archive contents without actually reading the archive files.

Introduces some new functions:
- list_archive_contents()
- smb_adddfile_withlist()

A new SMB convenience variable ("tail", aliased as "content" for a file).
A new file detail level ("file_detail_content", exposed in JS as FileBase.DETAIL.CONTENTS) which adds a "content" array property to file metadata objects for JS FileBase.get().

Files already added to the new filebases won't have this archive content automatically - I'm looking into that now (likely a new or updated JS script to run).

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

It should be either EACCESS or EAGAIN, but still, could be useful to know.

end of the file.

in smb_open*() when creating msgbase files.
smblib wasn't using the same default file creation mode (permissions) as
the rest of the Synchronet executables. smblib was creating msgbase files
as user read/writeable *only* (no group or other permissions) - so the umask
value for the group/other permissions flags had no effect on msgbase files
created via smblib.
This could lead to permissions issues for other users/groups on *nix systems
trying to access (read or write) msgbases. No change for non-*nix systems.

GCC (worked fine in MSVC) :-(

Set smb.last_error strings in new voting/polling functions on failure.

If the specified or detected net_type is not Internet, only store the address
portion of the email address in the *NETADDR hfield.
If the net_type argument is a NULL pointer, automatically add the *NETTYPE
hfield too.
New functions:
- smb_netaddr_type() - returns the string/name of a specified net_type.
- smb_get_net_type_by_addr() - parses just the network address field.
Change short/ushort's to int16_t/uint16_t's.
Remove date from copyright.

msg scans). Fixed mail.sid corruption bug "the right way" {tm}.

mail.sid corruption (blocks of records getting zero'd out).

stream is already open.

different definitions for DLLCALL/EXPORT at different times (also solved with
the removal of multiple inclusion protection from xpdev/wrapdll.h).

(or any useful error number). It just returns a "non-zero" value, the same
"non-zero" value regardless of the cause of failure. Still not positive if
fread() sets errno in any/all CRTLs or not. :-(

This allows a single version of smb.lib to be linked with either single or
multi-threaded applications.

and allow for selective linking of objects from library archives.