1. 21 Feb, 2022 2 commits
    • Rob Swindell's avatar
      Change the semantics of the "Allow Sysop Logins" setting in SCFG->System · 3632b9c3
      Rob Swindell authored
      As Andre pointed out while documenting this setting on the wiki, the option seemed confusing: if a sysop could not login with "system operator access", how could they login at all? Answer: they could not.
      This setting used to be called "Allow Remote Sysop Logins", back when there was the concept of a "local login", so setting this option to "No" would mean that user accounts with sysop access could only be used for *local* login. But in Synchronet v3, there's really no such concept as a "local login", so it was changed to just "Allow Sysop Logins" (period) and not a lot of thought given to how/why a sysop would actually set to this "No" or what the implications would be (presumably, nobody ever sets this to "No").
      So rather than just get rid if the option altogether, I changed it to mean: an account with sysop access (i.e. level 90+) can still login, but any action that normally requires the system password will not be allowed. This includes the sysop-actions available in the FTP server when authenticating with <user-pass>:<system-pass> as the password. The sysop-user can still authenticate (and login), but none of those sysop-actions will be available to them.
    • Rob Swindell's avatar
      pthread_mutex_t is a CRITICAL_SECTION (not a pointer) on Win32 · b3c536e4
      Rob Swindell authored
      Partially revert Deuce's commit b4bc9c97
      This explains the EAccessViolation (stack corruption during sbbs startup) that sysops have reported when using the latest nightly builds.
  2. 20 Feb, 2022 3 commits
    • Deucе's avatar
      Add DISABLE_MKSTEMP_DEFINE support · cb76b146
      Deucе authored
      This macro as written won't compile on mingw32 due to the attributes
      on _mktemp().  This could be worked around, but it's easier to just
      disable it since I don't need it, and nobody else is building with
    • Deucе's avatar
      Fix socket_ioctl_ptr_t · 24a76496
      Deucе authored
      On Win32 it can't be defined until after winsock*.h is #included.
      On everything else, it needs to be a pointer.
    • Deucе's avatar
      Add socket_ioctl_ptr_t · 1d7b9805
      Deucе authored
      For Win32, this is actually the pointer type an ioctl() third
      argument needs to be.  For other OSs, this is basically what an
      FIONBIO third argument needs to be... there's really no restruction
      at all on what arguments after the second to ioctl() need to be.
  3. 19 Feb, 2022 8 commits
  4. 17 Feb, 2022 2 commits
    • Rob Swindell's avatar
      Strip carriage returns from extended descriptions · a77e846b
      Rob Swindell authored
      On Windows, CRs in extended descriptions could result in output of
      \r\r\n which could be displayed as 2 newlines (e.g. in notepad.exe).
      Since the \n -> \r\n expansion already happens on Windows stdout,
      we don't want them in the processed input (file metadata).
      As reported by DesotoFireflite (VALHALLA), thank you!
    • Rob Swindell's avatar
      Don't include both normal and extended file descriptions by default · b67a5a26
      Rob Swindell authored
      As pointed out by DesotoFireflite (VALHALLA), both the file's
      short/normal description and the extended description were being
      included in all file listings. This is probably want most sysops
      will want since the extended description is often used as the content
      of the short/normal description, resulting in repeated content. So,
      by default, if there is an extended file description, don't output
      the short/normal file description.
      If you want to include *both* the short and extended descriptions
      (for files that have both), include both the -ext and -desc command
      line options.
  5. 16 Feb, 2022 3 commits
  6. 15 Feb, 2022 1 commit
  7. 14 Feb, 2022 6 commits
  8. 13 Feb, 2022 2 commits
  9. 12 Feb, 2022 13 commits