1. 30 Nov, 2021 4 commits
    • Rob Swindell's avatar
      Add support for NTVDMx64 · 6b5de04a
      Rob Swindell authored
      Yes, you can run 16-bit DOS doors on 64-bit (x64) Windows now.
      
      Install NTVDMx64 (http://www.columbia.edu/~em36/ntvdmx64.html, it's not as onerous as it sounds) and re-enable DOS program support in SBBS (i.e. make sure "NO_DOS" is not in your sbbs.ini [bbs] Options value) and voila: DOS doors work.
      
      This change adds an empty init routine to sbbsexec.dll since older versions of NTVDM (which NTVDMx64 is based on) required one. Also, the sbbsexec.dll should be located in your Synchronet "exec" directory when using NTVDMx64 (in addition to or instead of your Windows/System32 directory).
      6b5de04a
    • Rob Swindell's avatar
      A batch file to build SBBSEXEC.DLL (may or may not require NTDDK?) · cae1b604
      Rob Swindell authored
      Using options (e.g. RINGBUF_MUTEX) from old sbbsexec.dsp
      cae1b604
    • Rob Swindell's avatar
      e45de995
    • Rob Swindell's avatar
      Fix sem_wait() call in vdd_read() · 0d4953ec
      Rob Swindell authored
      Introduced in Revision 1.16 (CVS)
      Wed May 10 08:52:11 2006 UTC (15 years, 6 months ago) by rswindell
      
      This was supposed to wait (block) until there was a new received
      byte (the ringbuf semaphore was signaled), but we were passing the sem_t
      value rather than the pointer to the sem_t. Since sem_t (on Windows)
      is a HANDLE (which is a void*), there was no compiler warning or
      error. Type-safety in C sucks.
      So, this just never worked (I'm assuming the call would just fail).
      
      I discovered this bug while working on NTVDMx64 support and in that
      case, this call would block/wait forever. Simple one character fix.
      0d4953ec
  2. 28 Nov, 2021 2 commits
  3. 26 Nov, 2021 10 commits
  4. 24 Nov, 2021 2 commits
    • Rob Swindell's avatar
      Implement FOSSIL function 0Dh (Keyboard read without wait) · a87ecd0f
      Rob Swindell authored
      As a work around for TradeWars 2 (v11.14 and v11.20) FOSSIL support:
      This door game would never call the FOSSIL "get received character"
      function (02h) . But I did notice that it was calling the "Keyboard
      read" functions. I never implemented the "Keyboard read" functions
      (figured the door game could read the keyboard itself if it wanted to),
      but appparently TW2 won't ever read the COM port (using function 02h)
      unless the Keyboard read function returns AX=0xFFFF (no keyboard data
      available). So now, I just do that and TW2 works (with FOSSIL I/O).
      
      Incremented the revision to 26.
      Logging the Git branch/hash and other helpful FOSSIL-debug stuff now.
      a87ecd0f
    • Rob Swindell's avatar
      Continuation of previous commit (support for UART-only doors on Windows) · 5cf93814
      Rob Swindell authored
      Needed the actually mapping of XTRN_UART -> EX_UART mode flag here.
      5cf93814
  5. 23 Nov, 2021 3 commits
    • Rob Swindell's avatar
      Allow FOSSIL mode of the Win32 virtual UART/FOSSIL driver to be disabled · 5b36ab9a
      Rob Swindell authored
      When configuring an external program, a Win32 sysop can now choose to *only* enable the virtual UART (and not the FOSSIL driver) feature of the Synchronet virtual UART/FOSSIL driver (dosxtrn.exe/sbbsexec.dll). Some programs (e.g. TradeWars 2) will always use the FOSSIL driver if one is detected and in order to force the use of COM/UART driver for I/O (if that is desired), then one must disable the FOSSIL driver. It's a rare use case, but I can see the potential need.
      
      Renamed the "Intercept I/O" option in SCFG to "I/O Method" and make it clear that "Socket" (for native programs) and "FOSSIL or UART" (for 16-bit DOS programs) is the default method (what was previously identified as "No" I/O Interception).
      
      If a sysop want to disable the virtual UART support (on Win32, e.g. so *only* FOSSIL is available to one or all DOS programs), they do that via their sbbsexec.ini file.
      5b36ab9a
    • Rob Swindell's avatar
      e8793d25
    • Rob Swindell's avatar
      MSVC 1.5c defines _MSDOS, not __MSDOS__ · b1fcb452
      Rob Swindell authored
      This change needed to build dosxtrn.exe (again).
      b1fcb452
  6. 19 Nov, 2021 1 commit
  7. 18 Nov, 2021 5 commits
  8. 17 Nov, 2021 1 commit
    • Rob Swindell's avatar
      Include twit-listed sender name in quotes in log message · 3c55d333
      Rob Swindell authored
      Since mail server log messages have their white-space condensed, it was not obvious why some sender's name would match a twitlist.cfg line that filters names beginning with a space: "\ *" because the initial space of the sender's name was condensed/combined with space before it in the log message.
      3c55d333
  9. 16 Nov, 2021 3 commits
    • Rob Swindell's avatar
      Initialize time zone variable (zone) · ed1f4ab1
      Rob Swindell authored
      As found and reported by Talisam author, apam (HAPPYLND).
      
      sscanf() won't initialize the buffer of the argument passed if the format string is not matched, so when there was no hexadecimal/SMB timezone value, the timezone specified in the ISO date/time string (if any) would be overwritten with 0, converted from the uninitialized 'zone' variable (unlikely to be valid hex-ASCII chars). Thanks apam!
      ed1f4ab1
    • Rob Swindell's avatar
      Add support for "name@address" syntax in twitlist.cfg · 47bb6691
      Rob Swindell authored
      where "address" is a QWKnet ID or path or a FidoNet originating address. Wildcards can be used (e.g. "*@VERT").
      
      For Trikester.
      47bb6691
    • Rob Swindell's avatar
      Add command-line specifier for user's real name (auto-quoted) · d1705535
      Rob Swindell authored
      %+ will now expand to the current user's real name, automatically enclosed in quotes if it contains any spaces.
      d1705535
  10. 12 Nov, 2021 4 commits
    • Rob Swindell's avatar
      Generate a MSGID kludge for netmail messages created by SBBSecho · e10b39d1
      Rob Swindell authored
      The "serialno" field is a bad/naive one (a time_t value), but this is really just an experiment for Ragnarok to see if this fixes issue #306 (with hotdoged receiving AreaFix responses/notices).
      e10b39d1
    • Rob Swindell's avatar
      Fix sbbsfile.nam contents: contained file's description instead of name · 7ff0e5c8
      Rob Swindell authored
      Found during review of previous commit.
      Introduced as part of the new file base branch merge (commit fcf58640).
      7ff0e5c8
    • Rob Swindell's avatar
      Don't write uploaded filename and description to env variables · 7fd781cd
      Rob Swindell authored
      Environment variables are shared among all threads of a process (e.g. all nodes of a instance of sbbs), so this scheme of passing the uploaded filename and description to an external file tester (upload processor) via environment variables has always been fraught with the possibility of failure or flakiness in Synchronet v3. Since I very much doubt that any upload processor is actually using this scheme, just remove it. Upload processors can and should)use the sbbsfile.nam and sbbsfile.des text files created in the node directory instead.
      7fd781cd
    • Rob Swindell's avatar
      Log an error and exit immediately when a local linked-node is configured · 5012efb1
      Rob Swindell authored
      When a linked-node (in echocfg->Linked Nodes) contains one of the local system's FTN addresses, display/log an error and exit immediately, e.g.:
      Configuration ERROR: Linked node #20 is your own address: 1:103/705
      
      I'd perform this check in EchoCfg, but:
      1. echocfg doesn't read the BBS's configuration files (where the local FTN addresses are configured), and
      2. some sysops just directly edit their sbbsecho.ini file
      5012efb1
  11. 08 Nov, 2021 1 commit
  12. 31 Oct, 2021 1 commit
  13. 30 Oct, 2021 1 commit
    • Rob Swindell's avatar
      Allow the client-name, server-name, and term-type to be passed as arguments · 334e768c
      Rob Swindell authored
      Optional, for easier use with game servers that take one of the 3 rlogin
      negotation parameters as the name/code of the door to execute. A telgate
      mode flag value argument must be provided (use 0 for default behavior)
      if you want to provide any of the other arguments to override the defaults
      (the user's alias, real name, and current detected terminal type).
      334e768c
  14. 23 Oct, 2021 1 commit
    • Rob Swindell's avatar
      Fix segfault after batch-upload when no "uploads" dir specified · 7dc1bc79
      Rob Swindell authored
      When there's no "uploads" directory configured by the sysop, cfg.upload_dir will be set to INVALID_DIR, which cannot be used as an index into cfg.dir[] to determine if the time used for uploading the files should be "given back" to the user.
      
      In v3.18, we used the first file in the upload queue, if there was one, else fell back to the "uploads" dir (which had to have been defined if there were no files in the queue). So this illegal array indexing was a regression in v3.19.
      
      Reported by Zoltán Gábor on Facebook
      7dc1bc79
  15. 19 Oct, 2021 1 commit