GitLab

Resolve error reported on irc with Ubuntu (don't know what version):
<rjwboys> ok now i get filedat.c:896:3: error: unknown type name ‘la_int64_t’

This has the effect of the file being listed as absent/deleted in the listing that's in memory. As requested by Phil, plt via irc.

Moving a file after this change did result in a crash once, but I couldn't reproduce it with a debugger attached.

Since we're cleaning up warnings... this will break the Windows build for now.

While we're doing that, actually use it in SyncTERM so the offline
scrollback retains fonts.

Also, fix an issue where the current mode would be updated with
the custom parameters when you changed them.

Finally, remove some unused variables.

New text.dat string:
- EditExtDescriptionQ

Removed text.dat string:
DeleteExtDescriptionQ

Was passing the address string twice, so the port appeared as an invalid number.

Altere reported via IRC:
!ERROR -1 (113) connecting to passthru socket

It might be helpful to know the address the passthru socket is bound to and the connection is being attempted on, so log that with the error.

This is the likely cause of Phil's reported errors when removing files:
access=-110 info=smb_removefile name not found

The only way I was able to reproduce these errors was to attempt to remove the same file multiple times in the same file listing. In other worse, use 'R', remove a file, then 'P'revious back to the first file and try to remove it again. Or to remove it a file from the batch flag prompt and then attempt to remove it again. <shrug>

This eliminates any ambiguity about what exact version was in use when each error is logged.

CID 330960, 330967, 330988

If the file doesn't already have a description, f->desc may be NULL.
Remove the redundant user name in the "removed file" log message.

This may have contributed to plt's file editing woes.

Fix issue reported by Jay Crutti.

CID 331582

I haven't played with this chat pager in *years*! The lowest tones were inaudible (raise the range from 0-800Hz to 400-1200Hz).
Increase the msgabort() tone from 1 to 10ms, sounds like those computerized voice recognition phone systems now.

Remove the redundant "<user> paged you to chat" notifications (and log message) when turning *off* the chat pager.

by adding a 'clear' argument to msgabort() that defaults to false. Pass true to check-and-clear.
checkline() is a NO-OP, so start eliminating "calls" to it.

... upon console abort (Ctrl-C).

Now, just 'E', then 'D' from the batch flag prompt has you editing a file description - rather than going through all the prompts for uploader name/date, etc.

Added text.dat string FileInfoEditPrompt.

Does not allow rename of file from this prompt - perhaps it should?

Resolves issue #263.

Wrong arguments passed to loadfiles() caused only index to be read.

As reported by plt via irc:
ERROR (smb_putmsghdr illegal header length increase: 70 (1 blocks, 0 hfields, 0 dfields) vs 0 (0 blocks)) removing file from database

Also, replace old CVS rev with Git branch and hash.

And for everyone: use delfiles.js instead (e.g. with jsexec).

Or detail level is MAX.

Sorry for the impending imminent merge hassle Deuce!

Do this in JS and use JSON for format instead of .ini.

The old "content" array property goes away.

<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> append key into keybuf: 4E (N)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> Executing external: /sbbs/exec/sexyz 14 -Telnet sz /mnt/disk1/dl/COCO/AGI/agi-xmas.zip
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: Synchronet External X/Y/ZMODEM  v3.0  master/23b741a1  Copyright Rob Swindell
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File skipped by receiver
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File Skipped
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !0 Aborting Transfer (Sending ZABORT)
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 !ERROR 11 receiving from socket 14
<plt> May 13 00:39:40 sbbs synchronet: term Node 1 input thread terminated (received 365 bytes in 35 blocks)

Not sure why this isn't happening for other sysops - perhaps plt was spying on the node?

This was really slowing down the upgrade_to_v319 and there's no current consumer of the data.

Consider adding back in JSON format later or just leave it to JS things to use for JSON-formatted metadata.

Don't use iniSet* since we know we're not updating existing ini entries. Use strListAppendFormat() instead.

The fread() usage here did not need "addressing" (Commit 1b56dc96).

This caused messages posted via smbutil to be short (e.g. 0 or 1 bytes
in length). Reported by Accession via Idle Relay Chat.

Also, don't call strlen() on msgtxt which could be NULL, causing segfault
in final printf() callin in postmsg().

This should address issue # 261.
Before April 19, 2016, area-linked nodes were required to be listed as nodes in sbbsecho.ini:
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/sbbsecho.c?revision=3.6&view=markup
I'm not sure why the change was made to only require that there be a wildmatch for each area-linked node. So just make it a configuration option. <shrug>

Also removed the trailing "..." for every top level menu item in echocfg.

It's very tricky to defeat the auto-pause to have your own custom prompt at  rows-1. So going back to having  a blank line before the batch prompt.

If a sysop wants a *blank* line before the batch flag prompt, they can put that (or a conditional blank line, even better) in their text.dat (BatchFlagPrompt). For now, I'm thinking no blank line before the prompt is better use of the screen.