1. 18 Jan, 2021 2 commits
    • Rob Swindell's avatar
      Safe string handling with config-load error messages · 99dbeb14
      Rob Swindell authored
      We were just trusting that the error strings would be shorter than 256 (usually), but since we're including paths and strerror() results, we really have no control over the length of the error strings. So enforce some healthy boundaries. This could explain the crashes that Divarin of Mutiny is seeing with SCFG on WinXP or maybe it was the truncsp(strerror()) stuff that was just removed as well. We'll see...
    • Rob Swindell's avatar
      Change STRERROR() to be just an alias for strerror() on all platforms · 4e2567ad
      Rob Swindell authored
      Its a terrible idea to modify the return value of strerror() on any platform. strerror() can (and often does) return immutable string constants - don't try to modify that string even if it does end in trailing white-space (find another solution to that). This change only affects non-*nix builds since we were already doing the right thing for *nix.
  2. 17 Jan, 2021 2 commits
    • Rob Swindell's avatar
      Don't include message number in origaddr portion of FTN NetMail MSGIDs · fca30919
      Rob Swindell authored
      Some old/unsupported FidoNet software (NetMgr? Squish?) reportedly parse addresses from MSGID control/kludge lines in NetMail messages to determine the source and/or destination address. This is clearly a bad idea for a lot of reasons, but to improve compatibility, let's not include the message number (or an '@') in the origaddr field for NetMail messages. This does slightly increase the chance of a duplicate MSGID being accidentally generated if the "mail" base is renumbered. No change for EchoMail MSGIDs (where dupe detection and threading still benefit from the additional entropy).
      For Watchman.
    • Rob Swindell's avatar
      Deuce wants js.exec() to support non-number return values via exit_code · a4fd167b
      Rob Swindell authored
      <@Deuce> Just saying that if someone does the work of exit_code = {thing: function(x) { return secretsauce }); exit(); they should get away with it.
  3. 16 Jan, 2021 1 commit
    • Rob Swindell's avatar
      Fix js.exec() returned nul" unless exit() was called explicitly · da7c67c9
      Rob Swindell authored
      Don't use the "exit_code" property value as the return value of js.exec() unless it's a number. As reported by mlong (thanks).
      Also, "exit_code" was being set to null (instead of void/undefined) in js_PrepareToExecute(). I think this was just an oversight or typo by Deuce from his commit of 5 years ago (f3256d81). Since we're comparing exit_code with JSVAL_VOID in other places to determine if it was actually set, this appears to be a long standing bug.
  4. 15 Jan, 2021 2 commits
  5. 14 Jan, 2021 3 commits
  6. 13 Jan, 2021 3 commits
  7. 12 Jan, 2021 3 commits
  8. 11 Jan, 2021 13 commits
  9. 10 Jan, 2021 2 commits
  10. 09 Jan, 2021 2 commits
    • Rob Swindell's avatar
      Don't delete pack####.now upon FTP-logoff · 3ead8a4d
      Rob Swindell authored
      When a user logins to the FTP server concurrently, this creates a
      race condition with an/the other FTP session that may be creating/
      downloading a QWK packet. On Vertrauen, this results in the
      occasional error removing the file since it was removed unexpectedly:
      !ERROR 2 (No such file or directory) in main.cpp line 2747 (event_thread) removing "/sbbs/data/pack1111.now" access=0
    • Rob Swindell's avatar
      Merge branch 'mlong/lore' into 'master' · d961570d
      Rob Swindell authored
      xtrn install lore
      See merge request !70
  11. 08 Jan, 2021 2 commits
  12. 07 Jan, 2021 2 commits
  13. 05 Jan, 2021 3 commits