1. 10 May, 2021 1 commit
  2. 28 Apr, 2021 1 commit
    • Rob Swindell's avatar
      Add a separate "area tag" string configured per sub-board · fa0a154e
      Rob Swindell authored
      According to  Lupine Furmen (FURFOL):
      It says in the help that the field is used for both the Newsgroup name AND the
      Fido Echo-tag.
      These really should be 2 different fields.
      Now, the echo/area tag is usually configured in the area file (areas.bbs) and so does not need to match *any* string configured in SCFG. But since an area file *can* be generated from SCFG (Export Areas option) and its possible to use SBBSecho withOUT an area file at all, then it's possible someone would like to have their FidoNet-style area tags configured different from any other strings related to a sub-board (e.g. newsgroup name) - why? I'm not clear, but there it is: another string that  a sysop can set (or not).
      Since I'd recently added an area tag field per directory for use by hatchit.js, this does create some logical symmetry. And there were enough free bytes per-sub in the msgs.cnf, so why not.
  3. 04 Apr, 2021 2 commits
  4. 19 Mar, 2021 1 commit
  5. 22 Feb, 2021 4 commits
  6. 19 Feb, 2021 1 commit
    • Rob Swindell's avatar
      Automatically route in-transit mail to points to boss nodes · 45ced2a3
      Rob Swindell authored
      If the destination point node is not a linked node (does not exist in sbbsecho.ini), but the boss node is linked, automatically route to the boss node. The log entries look like this when this happens:
      "Routing packet (%s) to boss-node %s"
      "Routing NetMail (%s) to boss-node %s"
      For poindexter FORTRAN (REALITY) - test results appreciated.
      Incremented SBBSecho version to 3.13.
  7. 15 Feb, 2021 3 commits
    • Rob Swindell's avatar
      Address Coverity-reported issues · 68990cd8
      Rob Swindell authored
      Hopefully not introducing any bugs in the process.
    • Rob Swindell's avatar
      Address Coverity-reported issues · 0c441424
      Rob Swindell authored
      Hopefully not introducing any bugs in the process.
    • Rob Swindell's avatar
      When replying to PING netmails, use the destination addr as the origaddr · 53d31031
      Rob Swindell authored
      As tested and reported in FIDONEWS by Michiel van der Vlist, 2:280/5555, SBBSecho would use the "best match" FidoNet AKA for the originating address when replying to PING netmail messages and not necessarily the original destination address of the ping request. For systems that have multiple addresses (AKAs) that could be considered appropriate originating addresses for the requesting node address (e.g. multiple addresses in the same zone or zone/net), this could cause a confusion for the PING requester.
      The create_netmail() function now accepts an optional source (orig) address parameter and the PING response logic passes the netmail's destination address for the reply message's originating (source) address.
      I noticed that AreaMgr responses also follow the same logic as PING responses (just use the best-fit AKA, not necessarily the same address as the original request's destination address) - but I did not choose to address that "issue" at this time.
  8. 14 Feb, 2021 1 commit
  9. 18 Jan, 2021 1 commit
    • Rob Swindell's avatar
      Safe string handling with config-load error messages · 99dbeb14
      Rob Swindell authored
      We were just trusting that the error strings would be shorter than 256 (usually), but since we're including paths and strerror() results, we really have no control over the length of the error strings. So enforce some healthy boundaries. This could explain the crashes that Divarin of Mutiny is seeing with SCFG on WinXP or maybe it was the truncsp(strerror()) stuff that was just removed as well. We'll see...
  10. 25 Dec, 2020 2 commits
    • Rob Swindell's avatar
      Use QWKnet ID of originating system when imported via QWKnet · c590c437
      Rob Swindell authored
      Update to previous commit.
    • Rob Swindell's avatar
      Add/use new FTN "BBSID" control paragraph (kludge line) · f257f2ff
      Rob Swindell authored
      Advertise the system's QWK-ID (a.k.a. BBS ID) in exported echomail messages. This will allow correlation of avatars that were imported via SYNCDATA carried via QWKnet (e.g. DOVE-Net) with messages imported from those same BBSes via FTN.
      The alternative was to have SYNCDATA Avatar messages include all the AKAs of each BBS (in the body text), but that was looking like a rather complicated solution. This approach (the BBSID kludge) seems a much simpler solution.
      I still need to implement the JS side of this solution however (for avatar lookups using the FTN BBSID), but this was the first important step.
  11. 13 Dec, 2020 1 commit
  12. 10 Dec, 2020 1 commit
    • Rob Swindell's avatar
      Don't repeate mail "comment" headers in exported netmail msgs · a1e12784
      Rob Swindell authored
      smb_getmsgtxt() returns any "comment" headers as part of the message body text, and has since 2003.
      When I added mail->netmail (stored message) export support to SBBSecho v3, I duplicated this logic, so comment headers were added *twice* to exported netmail messages. Oops. I didn't notice until today when playing with forwarding-to-netmail (FTN).
      Also noticed and fixed: any comment headers in posted messages (unlikely/uncommon) would not be exported to EchoMail messages. Use the correct smb_getmsgtxt() mode flags ("NO_TAILS" instead of "BODY_ONLY") - I know, not great names.
  13. 23 Nov, 2020 1 commit
    • Rob Swindell's avatar
      The great C function dependency refactor of 2020 · c6808b3f
      Rob Swindell authored
      The goal of this commit is that: only modules that either are part-of sbbs.dll/libsbbs.so or need to link with/use that library, will #include "sbbs.h" and thus be dependent on its subsequent includes (e.g. cryptlib.h, jsapi.h). This should mean extdeps.mk can be trimmed way down.
      I also removed CVS keyword/comments and trimmed up the boilerplate copyright notice in modified and added source/header files in this commit.
      There is no functional change in behavior in this comment.
  14. 22 Nov, 2020 1 commit
    • Rob Swindell's avatar
      Fix netmail forwarding (new feature) · cbda86ec
      Rob Swindell authored
      The recipient net-addr/type was always being over-ridden a bit further down in the code. Don't do that.
      Also, log a message (sbbsecho.log) indicating that a message was forwarded ("Forwarding message ...").
      For geneb.
  15. 21 Nov, 2020 3 commits
  16. 06 Nov, 2020 1 commit
    • Rob Swindell's avatar
      Replace ctype.h function calls with new MSVC-safe XPDEV macros · 8a7b7308
      Rob Swindell authored
      I'm fed-up with MSVC assertions in ctype functions (e.g. isdigit, isprint, isspace, etc.) when called with out-of-range (e.g. negative) values.
      This problem only affects MSVC debug builds, but if you run them (like I do), these things are like little time bombs that can drive you crazy (knocking your board out of service).
      The new macros names are bit more descriptive as well.
  17. 22 Oct, 2020 1 commit
  18. 26 Sep, 2020 1 commit
    • Rob Swindell's avatar
      Don't attempt to parse origin addr from origin lines in NetMail msgs · da486a78
      Rob Swindell authored
      Apparently, some versions or configurations of Mystic BBS will include an
      Origin Line in FTN NetMail messages. That would've been okay for SBBSecho,
      except these origin lines do not contain an FTN address (in parenthesis).
      So, firstly: when importing NetMail messages (subnum=INVALID_SUB), don't
      attempt to parse any Origin Lines. Secondly, fix up the Origin Line parse
      code a bit better detect the case when no FTN address is actually present.
  19. 25 Sep, 2020 2 commits
  20. 17 Aug, 2020 1 commit
  21. 16 Aug, 2020 2 commits
    • Rob Swindell's avatar
      Fix issue with jsexec being used for CGI scripts · 54431b31
      Rob Swindell authored
      If jsexec is used for a CGI script and the SBBSCTRL env var was not
      set, a warning would be printed (to stderr), even if the -c option
      was used to specify the path to the ctrl dir.
      get_ctrl_dir() now accepts a boolean argument to specify whether to
      print a warning when the default value ("/sbbs/ctrl") is used.
      Pass FALSE for jsexec, TRUE for other callers (currently).
    • Rob Swindell's avatar
      Commit with CVS Keywords expanded. · dfa1a0a4
      Rob Swindell authored
  22. 19 Jul, 2020 2 commits
  23. 16 Jul, 2020 1 commit
  24. 20 May, 2020 1 commit
    • rswindell's avatar
      Fix issue reported by Alterego: · 47411e10
      rswindell authored
      Don't auto-add sub-boards to the area file if the echotag is already in the area file (but marked as pass-through or associated with a different sub-board already). This configuration could result in the same sub-board(s) being auto-added to the area file for every invocation of sbbsecho.
  25. 02 May, 2020 1 commit
  26. 01 May, 2020 1 commit
  27. 30 Apr, 2020 2 commits
    • rswindell's avatar
      Remove unnecessary typecasts. · 07545606
      rswindell authored
    • rswindell's avatar
      When importing messages into a local msgbase that contained an origin line · 4364fd73
      rswindell authored
      but no tear line, I noticed that the initial space before "* Origin" was absent
      from the tail. It turns out the missing space character was being appended to
      the end of the body text. While investigating why that was, I was dismayed at
      the cruftiness of code but totally suprised that there was 80-column word-wrap
      logic in here (!). Removed that word-wrap logic <blush> and fixed the origin
      thing. More clean-up coming up next.