Specifically, have errors mean the fd is "ready".

Also, fix some extra revent clearing and a spy socket issue while
we're looking at this code.

Should fix issues with CGI scripts that close stdin/stdout but do
not terminate, and maybe deal with some other corner cases at the
same time.

Tabs are the shit.

This macro has expanded to nothing for a while now and even before, the usage was misguided and unnecessary as explained in this video: https://www.youtube.com/watch?v=cjotPqQxxAY

CID 33232

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

This appears to work and the event handler *should* work on other
event types already.

Note, this is *nix-only due to the use of poll().  select() will
need to be used for Windows to keep XP compatability.

Looks like I was partially restoring old code before I stopped.

Rather than depending on _WIN32 which is silly, make it clear what
exactly is being done and why.

Note that the spy socket stuff and some external stuff on *nix have
had the select() implementation removed.  To support using select()
on !Win32 will require de-refactoring that's not really worth doing.
Instead, just use #error and reference the commit where the old
code can be found.

Still needs updates in services_thread(), CGI stuff in websrvr.c,
and sbbs_t::external()

It fixed an issue in js_socket.c, no reason to expect better
behaviour with TLS.  This may fix SZ YModem-G transfers on
cvs.synchro.net...

Something weird is happening to the cryptlib session when SZ sends
a lot of data... no real clues left.

This issue may actually be a rekey issue, to clear this, we need
to call cryptPopData(), but we can pop zero bytes.

In this case, re-try the flush.

During YModem-G transfers, the previous 5-second timeout was
exceeded.

JavaScriptOptions bit-field can be set in sbbs.ini and jsexec.ini to over-ride the default JS compiler options which have been changed from 0 to (options previously only used by JSDoor):
JIT | METHODJIT | COMPILE_N_GO | PROFILING

* JIT - TraceMonkey
* METHODJIT - JägerMonkey
* COMPILE_N_GO - compile-time scope chain resolution of consts
* PROFILING - Choose between TraceMonkey and JägerMonkey at compile-time based on profiling results

Other options available but not enabled by default:
* STRICT - warn on debious practice (i.e. similar to "use strict")
* WERROR - convert warnings to errors
* VAROBJFIX -  use last object on scope chain as the ECMA 'variables object'
* RELIMIT - Throw exception on any regular expression which backtracks more than n^3 times, where n is length of the input string
* ANONFUNFIX - Disallow function () {} in statement context per ECMA-262 Edition 3.
* METHODJIT_ALWAYS - Always whole-method JIT, don't tune at run-time.

Also:
- Fixed JS warning string formatting (missing space separator).
- Removed an extraneous new-line in lprintf() call in mailsrvr.
- Added basic assertEq() global method to jsexec, required when running SpiderMonkey test scripts.

I noticed "DAILY ... Semaphore signaled" in the event thread log output. Now fixed.

This function is the fastest file-copy method (or should be), but does not have any progress indication.

protected_*_adjust() only adjusts now.

Deal with the resulting warnings (using (void)).
Deal with the incorrect integer to protected_int* assignment in services.c
(just don't support server.clients property reading in service scripts).

Also, the strcpy()->SAFECOPY() change in ftpsrvr.c was wrong, caught
by GCC warning - oops.

Also, fix things that incorrectly reach into the protected_*_t to
incorrectly access values.

Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.

Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.

Hopefully not introducing any bugs in the process.

Hopefully not introducing any bugs in the process.

Don't return an error if the node#/node.cnf file can't be opened for all uses of load_cfg() except from the terminal server. This fixes #214 for Tracker1

We were just trusting that the error strings would be shorter than 256 (usually), but since we're including paths and strerror() results, we really have no control over the length of the error strings. So enforce some healthy boundaries. This could explain the crashes that Divarin of Mutiny is seeing with SCFG on WinXP or maybe it was the truncsp(strerror()) stuff that was just removed as well. We'll see...

Defaults to K_EDIT.

Might as well, could be useful to display in something like umonitor in the future.

Paves the way for utilities like umonitor to show client details for node connections (e.g. IP address, hostname, connection duration, etc.)

Recompiling ver.cpp only now, so need link ver.obj/o with the various targets now. I'll need to update the objects.mk for the *nix builds, next.

There is no actual TCP-client when a timed event is executing, so don't create one in the JS context when the socket is invalid.