1. 16 Apr, 2021 1 commit
  2. 15 Apr, 2021 1 commit
  3. 14 Apr, 2021 3 commits
    • Rob Swindell's avatar
      Refactor putuserrec() · 7db3b623
      Rob Swindell authored
      This started with a Coverity issue (CID 33230) which got me looking at this function and wondering: why is str2 being NUL-terminated here? Why is the length of str2 to be calculated on successive lines? What is with this (long)((long)((long)((long)) typecast?
      This was some of the oldest code in Synchronet (along with a lot of the other functions in this file). I tried to keep as much intact as possible while still improving the logic and readability.
    • Rob Swindell's avatar
      Add/use P_REMOTE print-mode flag to bputs() · 12fde4ab
      Rob Swindell authored
      Do nothing if online != ON_REMOTE. Eliminates some if(online == ON_REMOTE) clauses.
    • Rob Swindell's avatar
      Debug the "thread_back field missing" error · 908618c8
      Rob Swindell authored
      Some QWKnet vote messages are failing:
      evnt unpackREP <ENSEMBLE> !ERROR 2 (No such file or directory) in qwk.cpp line 1146 (qwk_vote) writing "/sbbs/data/subs/dove-gen" access=-105 info=smb_addvote thread_back field missing
      Catch this problem a little higher up (in votemsg()) and log the message's reply-IDs to help determine what's the root-cause here. Don't bother calling smb_addvote() if thread_back is 0.
  4. 13 Apr, 2021 6 commits
  5. 12 Apr, 2021 10 commits
  6. 10 Apr, 2021 2 commits
  7. 08 Apr, 2021 5 commits
    • Rob Swindell's avatar
      Pretty much a complete re-write and still a work-in-progress, but useful · 46c91758
      Rob Swindell authored
      The biggest difference is that you can combine all files from multiple dirs
      into a single sorted list and you can sort on any property (field) value.
      The byte/credit format is very customizeable, the output format is completely
      By default, just the filenames are output, but either use '-ext' or one or
      more '-v' values to add more fields. Use -p=list to specify a comma-separated
      list of properties to print.
    • Rob Swindell's avatar
      When bytes is falsey and size is > 0 but < 1000*1024 don't return "0K" · c1fc6708
      Rob Swindell authored
      Instead, return the fractional size in KB's with 2 digits of precision.
      Fixed up some of the variable names.
    • Deucе's avatar
      Fix sizeof() target. · 77933477
      Deucе authored
    • Deucе's avatar
      When a callback event is handled, get remote_addr · 287ee6e4
      Deucе authored
      Prevents weird issues with getting remote address.
    • Rob Swindell's avatar
      Sorted loadfiles() results were corrupted when detail was < normal · 4391ca75
      Rob Swindell authored
      When only reading the index (detail = file_detail_index), smb_getfile() just sets the file->name convenience pointer to point to the name in the index. Then when loadfiles() would sort the list, these pointers would not be adjusted (so they would point to the wrong names) resulting in a corrupted file list (e.g. name/size mismatches and no logical sort order).
      The solution is to call smb_getfile() on each file *after* the read index records have been sorted.
      This also means that the sort-by-name routines needed to always sort using the index name and not the convenience pointer (which is NULL in this case).
      While fixing this, I noticed there was no bounds checking in the loadfiles() and loadfilenames() read-loops, so if the indexes happened to be longer than the total_files value from the status header, a buffer under-alloc/overflow would occur and a likely crash as a result. So stop reading the index when the expected maximum number of index records have been read.
  8. 07 Apr, 2021 12 commits