- 27 Sep, 2020 2 commits
-
-
Rob Swindell authored
Also, don't include "error" in the Error message. Also, socket error strings can be quite long on Windows (e.g. >128 chars) so place at the end of the Error message.
-
Rob Swindell authored
-
- 26 Sep, 2020 15 commits
-
-
Rob Swindell authored
This enables much easier debugging of logged exceptions/errors.
-
Rob Swindell authored
Vote messages and poll closures are not displayed to users as messages, so exclude them from the total "posts" returned from getposts(). This uses the new smb_msg_count() function which is slower than simply checking the size of the index file (*.sid) and dividing by the index record size. So for sub-boards that don't support voting, use the old/faster scheme.
-
Rob Swindell authored
The inferred message type should match the stored message type. Confirm that.
-
Rob Swindell authored
Don't exclude polls form the message count used for max_msgs enforcement during maintenance.
-
Rob Swindell authored
In support of message bases with vote-messages and poll-closures: smb_msg_type() returns an enum smb_msg_type inferred from the combination of attribute flags specified (should match msghdr_t.type). smb_msg_count() calculates the number of message index records of the specified type(s) (a bit-field) by reading the message base index file. This value should only used for info/display purposes, so no locking is performed to return the result as fast as possible. This allows an accurate number of "posts" (posted *messages*) to be queried and displayed to a user when appropriate (e.g. instead of smb.status.total_msgs or just the size of the index file divided by the size of an index record). In that case, since vote messages and poll closures aren't displayed as messages to users, exclude those from the count to reduce confusion. For message bases that don't support voting, this scheme is not necessary.
-
Rob Swindell authored
-
Rob Swindell authored
-
echicken authored
-
Rob Swindell authored
-
Rob Swindell authored
only if there's not already a daily event already configured.
-
Rob Swindell authored
Also, I put this in my login.js: if(client.ip_address == "::1") js.exec("jsdocs.js", {});
-
Rob Swindell authored
Altere reported that listing users with access to a sub-board with an Access Requirement String (ARS) set to "SYSOP" would list all users as having access. The problem was the use of the "SYSOP" macro which checks the *current* user online (not the subject of the ARS check). Fixed by not using the SYSOP macro.
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
Apparently, some versions or configurations of Mystic BBS will include an Origin Line in FTN NetMail messages. That would've been okay for SBBSecho, except these origin lines do not contain an FTN address (in parenthesis). So, firstly: when importing NetMail messages (subnum=INVALID_SUB), don't attempt to parse any Origin Lines. Secondly, fix up the Origin Line parse code a bit better detect the case when no FTN address is actually present.
-
- 25 Sep, 2020 9 commits
-
-
Rob Swindell authored
-
Rob Swindell authored
Don't set the object's private data with freed data pointers.
-
Rob Swindell authored
-
Rob Swindell authored
Wow. This is another one of those "forever bugs".
-
Rob Swindell authored
-
Rob Swindell authored
Left it there, but commented out, just in case anyone needs it later. But it was reported that the setcap line failed anyway: Sep 24 09:20:15 bbs setcap[21466]: Failed to set capabilities on file `/sbbs/repo/src/sbbs3/gcc.linux.*.exe.*/sbbs' (No such file or directory) Sep 24 09:20:15 bbs setcap[21466]: The value of the capability argument is not permitted for a file. Or the file is not a regular (non-symlink) file
-
Rob Swindell authored
At the request of alterego (ALTERANT), if a sub-board has a "post semaphore" configured, signal (touch) it whenever a message is imported via SBBSecho into that sub-board.
-
Rob Swindell authored
I changed the name from "Cyber-Net" to "CyberNet" because this value is used as the 5D domain name which is limited to 8 characters. Everything else is as Chad provided it.
-
Rob Swindell authored
Don't re-read the configuration - we already have it in memory, just pass it by reference to createdefaults(), so we don't need the SBBSCTRL environment variable (again). As reported by Michael Long via alt.bbs.synchronet. Also addressed the truncation of the new user chat handle as reported by GCC.
-
- 24 Sep, 2020 1 commit
-
-
echicken authored
Just a port of someone else's work, with minor alterations. For nolageek, best geek.
-
- 23 Sep, 2020 9 commits
-
-
Rob Swindell authored
Bug introduced in commit a2f5990b (Sept-11): By calling putuserrec() before modifying user->misc and then calling noyes(), we're giving an opportunity for the low-level node sync code to read the modified "useron" back from the database, thus losing the change we just made to user->misc. Instead, move the putuserrec() call to the end of the case statement. Another option would have been to turn off the NETMAIL flag before the first call to putuserrec(). Bug reported by Nugax (BYTEXCHG)
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
e.g. Hitting Ctrl-U while online, any nodes in "quiet mode" would not be shown to the user even though that user was a sysop. This is not how sbbs_t::whos_online() from getnode.cpp behaves. Now changed to behave the same as whos_online().
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
(e.g. logon, new-user, quiet mode) - these are value node status values with a user on the node. Also address GCC warnings about unsafe sprintf usage, e.g. warning: ‘%s’ directive writing up to 79 bytes into a region of size 59
-
echicken authored
-
echicken authored
Treat .asc, .msg, and .txt the same. For .asc, .msg, .txt, split the file on /\r*\n/ instead of assuming CRLF. We know what phil says about assumtion.
-
- 21 Sep, 2020 4 commits
-
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
-
Rob Swindell authored
-