GitLab

The QWKnet user look-up feature was broken as of commit e4fc5d04 (a year ago).

Just noticed this regression as Andre asked in IRC about looking up network users for netmail. This feature worked for QWKnet users/addresses, at least, and now will work again.

Users with the 'O' restriction (automatically set if a new user has the same "real name" as another account, and that's allowed by the sysop) will send netmail from their alias and not their real name to prevent impersonation of another user.

The internal line editor's quoting feature add some hard-coded strings ("Done" and "All") and the (L)ist key was hard-coded. Use the text.dat string (new and pre-existing) for these now.

Also, use the new sbbs_t *_key() methods for referencing the configured key bindings (via text.dat) for these common key-stroke commands.
Convert the text.dat strings for keys (e.g. YNQP) to uppercase always as well.

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

Sent to terminal user after successfully sending netmail:
- InternetMailSent
- FidoNetMailSent
- QWKNetMailSent

As requested by Keyop in irc.

Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.

Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.

Hopefully not introducing any bugs in the process.

Hopefully not introducing any bugs in the process.

Addresses Coverity's NEGATIVE_RETURNS bug-checker issue.

A bit of redundant code cleanup, no expected functional change.

Leave it to new users to do weird stuff and define a mail-forward loop. Outsmart them and don't allow forwarding when the destination is a local address (QWKnet, FidoNet, or Internet).

‘%s’ directive writing up to 255 bytes into a region of size between 103 and 128
reported by Nelgin.

I'm fed-up with MSVC assertions in ctype functions (e.g. isdigit, isprint, isspace, etc.) when called with out-of-range (e.g. negative) values.

This problem only affects MSVC debug builds, but if you run them (like I do), these things are like little time bombs that can drive you crazy (knocking your board out of service).

The new macros names are bit more descriptive as well.

Don't prompt a new user to forward email to their netmail address if they
provided an invalid netmail address (not supported by the system).

If a sysop has an invalid netmail address setup for forwarding, don't try to
forward email (or new user feedback) to that address.

Re-ordered the new user terminal questions a little bit (ask for the backspace
key first, to get earlier manual PETSCII detection). I'm not sure why I was
enabling AUTOTERM along with PETSCII before. Removed that as PETSCII cannot
be auto-detected.

Eliminate the hack in each server where it will over-write startup host_name
(with the configured Internet email address), if it's blank. This hack was
subject to a race condition where the parent app (e.g. sbbsctrl.exe) would
clear or re-initialize the host_name after the sever threads had initialized.
Instead, just use a function which will return either the startup->host_name
or (fallback to) scfg.inet_addr.

Set the "LOCAL" network-attribute on locally-created Internet email messages (no use currently, but seems prudent).
Set the KILLSENT network attribute for created Internet email messages when enabled in SCFG->Networks->Internet (new option).

the net-attributes header fields.

expressions

Added multiple Internet email recipient support.
I'll look into multiple FidoNet netmail support later as that code needs an
even greater overhaul in that process.

to eliminate a lot of copy-pasta.

The Fido "Stored Message" (*.msg) stuff is gonna get ripped out of these
functions (soon?) anyway.

auxattr flag since we normally want the attach file to be deleted automatically
when the message is delivered. SBBSecho now won't be deleting the file
attachment unless this flag (or the .msg \1FLAGS "KFS" equivalent flag) is set.

fidodefs.h:47:27: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
 #define FIDO_CHARSET_UTF8 "CHRS: UTF-8 4" /* FTS-5003 */
                           ^
writemsg.cpp:645:15: note: in expansion of macro 'FIDO_CHARSET_UTF8'
    *charset = FIDO_CHARSET_UTF8;

(e.g. applies to email and netmail now too).

(default: off) - when enabled, the current terminal width (columns) will be
saved in the msg header.
When using the internal msg editor or raw intput mode, the columns are always
saved in the message editor. fseditor.js should have this option enabled.

(JS bbs.post_msg()): If the WM_QUOTE mode flag is *not* set, then it will auto-
create the quote file (quotes.txt) and add the WM_QUOTE mode bit before calling
sbbs_t::writemsg(). So if existing JS scripts call bbs.post_msg(..., WM_QUOTE)
with a custom-created quote file (e.g. with msg tails), that'll still work as
before (e.g. DDMsgReader.js).

bbs.email() and bbs.netmail() now support an optional reply_header_object
argument which works like bbs.post_msg(). These methods (and the underlying
C++ methods: sbbs_t::email(), netmail(), inetmail(), all auto-create the
quote file now, when the WM_QUOTE mode flag is *not* set.

The auto-created quotes.txt now includes the plain-text version of MIME-encoded
messages.

the bbs.post_msg(), email(), and netmail() methods now all support reply
header objects that came directly from bbs.get_msg_header() *or* copies of
such header objects (but the auto-quoting feature won't work when supplied
this type of header object). So if passed a header object returned from
bbs.get_msg_header(), we can now use the message base (for auto-quoting) and
the underlying msg storage directly (no JS parsing necessary). This is what
the new js_GetMsgHeaderObjectPrivates() function is used for.

js_ParseMsgHeaderObject() (and the underlying parse_header_object() function)
now supports either an actual internally-generated msg header object (e.g.
returned from bbs.get_msg_header()) or one that is a copy or hand-constructed.

quotemsg() no longer tries to get a copy of the msg index/header. It shouldn't
have to since we can now get to underlying msg storage in the js_msgbase.c
via js_GetMsgHeaderObjectPrivates().

quotemsg() now reads only the plain-text portion of MIME-encoded messages.

As part of this effort, I modernized the method prototypes using default
argument values (e.g. WM_NONE for wm_mode arguments) and removed some
extraneous WM_EMAIL and WM_NETMAIL specifications (these wm_mode flags are
automatically added by the sbbs_t::email() and *netmail() functions).

savemsg() now *does* support reply-IDs/thread-linkage via the additional
'remsg' argument (when non-NULL).

Replaced some use of nulstr with NULL.

Replaced more boilerplate SMB open code with calls to smb_open_sub().

So I created a single add_msg_ids() function (mostly migrated from postmsg.cpp)
to make this incredibly easy so any/everywhere that adds a message to a message
base should be able to call it. This function also creates reply-IDs (when
relevant) and program ID (Fido-PID) header fields:
- FIDOPID (always)
- FIDOMSGID (if an echomail post)
- FIDOREPLYID (if an echomail reply-post)
- RFC822MSGID (always)
- RFC822REPLYID (if a reply)