GitLab

bytes have been sent!

"Sometimes" the write timeout value is used for read timeouts.  Since we
use a read timeout of zero, and a mutex, this can cause some serious delays
in SSH processing.  As a workaround, we set the write timeout to zero.
However, a flush failure has historically been fatal.

So, we now change the write timeout to one second just before a flush, and
have a flush timeout not be fatal anymore... we set it back to zero after
the flush.

The fiddling with the write timouts will be removed once the bug is fixed,
but the flush timout not being fatal may stay forever... add some comments
to remind us to remove the hack in the future.

attempt.

"unique" login attempt (e.g. hack attempt).

code merely introduced a 5 second delay in the Node 0 thread.

the challenge length is set and add a TODO comment there.

matches, send an M_ERR to the remote and leave the address list empty.

expect the Seen flags to be coherent across them... support this by leaving
the users IMAP status file open, and holding a lock on the first byte.

We now need to flush changes to the status file more often, and we need
to call file.flush() before unlocking.

nomd5 means "plain-text passwords are okay" (AllowPlainPasswords=true)

The *first* packet from the answering side *must* be an M_NUL "OPT TLS".
If this is the case, the originating size responds with an M_NUL "OPT TLS".
After this, the answering system performs a server TLS handshake, and the
originating system performs a client TLS handshake.

OPT CRYPT is not used in this case (ie: not crypt over TLS)

"user@" prefix.

(import netmail) command along with the '-n' option to set the recipient
net address (and network type). Previously, only Internet or QWK netmail
was supported.

bad login.

inbound Mystic sessions are failing (e.g. with Al@TRMB's BinkIt mailer).

with Synchronet.

(.sid file), don't divide the fread() results (it's already in number of
records read). This could cause msgbase maintenance to not take place
or corruption of a msg base.

my jsexec includes debug output... and this is super-normal.

Also, change READTIMEOUT back to zero since that issue is fixed now.

log messages.

SSLv3 (!) and even SSLv2(!!) clients still in the wild.  Sysops aren't
expected to be able to fix other peoples ancient broken stuff.

the SSH session.  Also, do an INFO level log entry to indicate what
happened to your socket.

missing "SSH" when logging channel use errors.

sends would cause MAC errors.

so support that.

for a match... which caused a memory leak.

Thanks scan-build!

So, we really should initialize sock to INVALID_SOCKET before calling it.

This should fix the "random descriptors are closed" issue.

to zero again.  Unfortunately, there appears to be a related bug where the
TX timeout is sometimes used for RX... that's OK, we'll just set them both
to zero.

Also, deal with secondary channels (ie: forwarded ports).  For now, we just
close these channels any time we get data on them.  In the future, we can
do scp/sftp pretty easily now... though neither is likely to ever work with
the sysop account due to the system password requirement.

This change ABSOLUTELY REQUIRES an updated cryptlib.  Windows guys don't
update until DigitalMan commits cl.lib or whatever it's called.